New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Test Vector): Add interop test for Go #1071

Open

rishav-karanjit wants to merge 37 commits into Golang/dev from testTestVector

Member

rishav-karanjit commented Dec 2, 2024 •

edited

Loading

Issue #, if available:

Description of changes:

Adds/Updates makefile, externs and go.mod file to run test vectors.
Bump smithy-dafny HEAD to latest commit of Golang/dev

Call-outs:

This PR adds github.com/dafny-lang/DafnyRuntimeGo/v4 v4.9.1 instead of v4.9.0 because of the performance issue found in v4.9.0
Update: I added this commands to the makefile itself. So, these commands runs with polymorph and transpile. Also added a TODO there.
~~Use this script on TestVectorsAwsCryptographicMaterialProviders directory before running the generated code to fix the known issues with Go:~~

#!/bin/bash

find .. -name "shim.go" | xargs sed -i "" 's/(_static \*CompanionStruct_Default___)//g'

rm -rf runtimes/go/ImplementationFromDafny-go/awscryptographymaterialproviderssmithygenerated \
      runtimes/go/ImplementationFromDafny-go/awscryptographymaterialproviderssmithygeneratedtypes \
      runtimes/go/ImplementationFromDafny-go/WrappedAwsCryptographyMaterialProvidersService \
      runtimes/go/TestsFromDafny-go/awscryptographymaterialproviderssmithygenerated \
      runtimes/go/TestsFromDafny-go/awscryptographymaterialproviderssmithygeneratedtypes \
      runtimes/go/TestsFromDafny-go/WrappedAwsCryptographyMaterialProvidersService

sed -i '' 's/_out0 = m_TestWrappedMaterialProvidersMain.GetTestVectorExecutionDirectory()/_out0 = GetTestVectorExecutionDirectory()/g' ./runtimes/go/TestsFromDafny-go/TestWrappedMaterialProvidersMain/TestWrappedMaterialProvidersMain.go

How to test this?

There are two ways to test it. Use either (i) or (ii).
1. Run make test_go
2. Run following commands:
  - make test_generate_vectors_go
  - make test_encrypt_vectors_go
  - make test_decrypt_encrypt_vectors_go

Squash/merge commit message, if applicable:

chore(Test Vector): Add interop test for Go

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rishav-karanjit added 13 commits

November 14, 2024 15:25


          Init test vector

096d426


          Add extern

06e04c2


          Add GetTestVectorExecutionDirectory extern

57cedf6


          rm redundant

12ed075


          fix path

4037f87


          Fix externs

fce02df


          Update makefile

d6017fb


          replace dafny runtime Go for now

c9a88c2


          replace dafny runtime Go for now

6971d70


          Commit runtime --revert later

7a2f114


          Update error message

cbdb72f


          Revert "Commit runtime --revert later"

49b3291

This reverts commit 7a2f114.


          Merge branch 'Golang/dev' of https://github.com/aws/aws-cryptographic…

f7be994

…-material-providers-library into testTestVector

rishav-karanjit temporarily deployed to Duvet CI

December 2, 2024 17:21

— with

GitHub Actions Inactive

rishav-karanjit added 2 commits

December 2, 2024 09:23


          Remove replace dafny runtime Go

c5d73e3


          Use 4.9.1 dafny runtime Go

fe27bc5

rishav-karanjit temporarily deployed to Duvet CI

December 2, 2024 17:25

— with

GitHub Actions Inactive


          formatting

e4100e0

rishav-karanjit temporarily deployed to Duvet CI

December 2, 2024 17:29

— with

GitHub Actions Inactive


          auto commit

03961b6

rishav-karanjit temporarily deployed to Duvet CI

December 2, 2024 18:55

— with

GitHub Actions Inactive

rishav-karanjit changed the title ~~Test test vector~~ feat(Test Vector): Add go support for test vectors


          go mod tidy

77fa487

rishav-karanjit temporarily deployed to Duvet CI

December 2, 2024 19:00

— with

GitHub Actions Inactive

rishav-karanjit changed the title ~~feat(Test Vector): Add go support for test vectors~~ feat(Test Vector): Add interop test for Go

rishav-karanjit marked this pull request as ready for review

December 2, 2024 19:12

rishav-karanjit requested a review from a team as a code owner

December 2, 2024 19:12


          bump to latest head

c47ac54

rishav-karanjit temporarily deployed to Duvet CI

December 2, 2024 19:32

— with

GitHub Actions Inactive

rishav-karanjit changed the title ~~feat(Test Vector): Add interop test for Go~~ chore(Test Vector): Add interop test for Go

github-actions bot commented Dec 10, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS


          auto commit

e1b1fcc

rishav-karanjit temporarily deployed to Duvet CI

December 10, 2024 00:32

— with

GitHub Actions Inactive

github-actions bot commented Dec 10, 2024

Detected changes to the release files or to the check-files action

github-actions bot commented Dec 10, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS


          auto commit

2aec202

rishav-karanjit temporarily deployed to Duvet CI

December 10, 2024 00:52

— with

GitHub Actions Inactive

github-actions bot commented Dec 10, 2024

Detected changes to the release files or to the check-files action

github-actions bot commented Dec 10, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS


          Update TestVectorsAwsCryptographicMaterialProviders/Makefile

69f14f3

rishav-karanjit temporarily deployed to Duvet CI

December 10, 2024 00:53

— with

GitHub Actions Inactive

github-actions bot commented Dec 10, 2024

Detected changes to the release files or to the check-files action

github-actions bot commented Dec 10, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

rishav-karanjit added 2 commits

December 9, 2024 16:53


          auto commit

e075d91


          auto commit

97f3a19

rishav-karanjit temporarily deployed to Duvet CI

December 10, 2024 00:59

— with

GitHub Actions Inactive

github-actions bot commented Dec 10, 2024

Detected changes to the release files or to the check-files action

github-actions bot commented Dec 10, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS


          Update smithy-dafny submodule to latest commit in main

fe19dfb

rishav-karanjit temporarily deployed to Duvet CI

December 10, 2024 17:24

— with

GitHub Actions Inactive

github-actions bot commented Dec 10, 2024

Detected changes to the release files or to the check-files action

github-actions bot commented Dec 10, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

lucasmcdonald3 mentioned this pull request

chore: add new externs for file append and cpu time #1126

Merged

ShubhamChaturvedi7 reviewed

View reviewed changes

Contributor

ShubhamChaturvedi7 left a comment

Why are so many CIs failing?

TestVectorsAwsCryptographicMaterialProviders/Makefile

+              # TODO: Remove these commands once smithy-dafny is fixed
+              # SED parameter is set on SmithyDafnySedMakefile.mk in smithy-dafny
+              polymorph_go:
+              	find .. -name "shim.go" | xargs sed -i $(SED_PARAMETER) 's/(_static \*CompanionStruct_Default___)//g'

Contributor

ShubhamChaturvedi7 Dec 16, 2024

Add a link to the broken windows CI sim.

Member Author

rishav-karanjit Dec 24, 2024

Done in this PR: #1157 because I had to make PR to main

github-actions bot commented Dec 16, 2024

@rishav-karanjit and @ShubhamChaturvedi7, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

rishav-karanjit changed the base branch from Golang/dev to main

December 16, 2024 23:47

rishav-karanjit changed the base branch from main to Golang/mpl

December 16, 2024 23:47

rishav-karanjit changed the base branch from Golang/mpl to Golang/dev

December 16, 2024 23:48

rishav-karanjit mentioned this pull request

chore(test vectors): Add interop test in Go with CI #1157

Open

github-actions bot commented Dec 24, 2024

@rishav-karanjit and @rishav-karanjit, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet