Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Add release-only "gitignore bypass" files #1010

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,26 @@ specification_compliance_report.html
*/**/.idea/
/compliance
/.smithy.lsp.log
*/**/Folder.DotSettings.user
*/**/Folder.DotSettings.user

# These files are not tracked.
# The release will force-commit these files, then the post-release commit will force-remove them.
# Scripts at /scripts/release will run on all files between START_RELEASE_IGNORED_FILES and END_RELEASE_IGNORED_FILES.
# START_RELEASE_IGNORED_FILES
# Ignore Python .dtr files
**/*py.dtr
# Ignore everything in TestsFromDafny-go
**/TestsFromDafny-go/**
# Ignore everything in ImplementationFromDafny-go...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also want to ignore TestsFromDafny-go ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Should this always be ignored? Or should we also commit this folder on releases?

**/ImplementationFromDafny-go/**
# ... except for files containing "smithygenerated"...
!**/ImplementationFromDafny-go/**/*smithygenerated*
# ... except for files containing "extern" ...
!**/ImplementationFromDafny-go/**/*extern*
# ... except for files named "shim.go" ...
!**/ImplementationFromDafny-go/**/shim.go
# ... except for go.mod ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Kms and Ddb, we also generate shim.go . But not sure if we want include the shims for other projects (I think we should).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the wrapped shims for testing local services? I think we commit those. (But we haven't released one yet, since the only place we've committed this is in MPL test vectors, which we've never released.)
If those are also just called shim.go, I'll add shim.go to this section

!**/ImplementationFromDafny-go/**/go.mod
# ... except for go.sum.
!**/ImplementationFromDafny-go/**/go.sum
# END_RELEASE_IGNORED_FILES
5 changes: 4 additions & 1 deletion .releaserc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,17 @@ module.exports = {
// Re-transpile Python code to update .dtr files as part of the release commit
"@semantic-release/exec",
{
prepareCmd:
prepareCmd: [
"make -C TestVectorsAwsCryptographicMaterialProviders transpile_python",
"sh scripts/release/git_add_gitignore_bypass_release_files.sh",
].join(" && "),
},
],
// Commit and push changes the changelog and versions bumps
[
"@semantic-release/git",
{
// TODO: Express Go artifacts
assets: [
"CHANGELOG.md",
...Object.values(Runtimes).flatMap((r) => Object.keys(r)),
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading