chore(release): Add release-only "gitignore bypass" files #1010
Conversation
## [1.7.5](lucasmcdonald3/aws-cryptographic-material-providers-library@v1.7.4...v1.7.5) (2024-11-15) ### Bug Fixes * **Python-Release:** Run validate tests from release commit ([41c0c94](lucasmcdonald3@41c0c94)) * **Python:** CMCs release lock for unhandled runtime exceptions ([#979](https://github.com/lucasmcdonald3/aws-cryptographic-material-providers-library/issues/979)) ([1510b77](lucasmcdonald3@1510b77)) * return error on interrupted sleep ([#993](https://github.com/lucasmcdonald3/aws-cryptographic-material-providers-library/issues/993)) ([f49460a](lucasmcdonald3@f49460a))
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
| **/*py.dtr | ||
| # Ignore everything in ImplementationFromDafny-go... | ||
| **/ImplementationFromDafny-go/** |
There was a problem hiding this comment.
You might also want to ignore TestsFromDafny-go ?
There was a problem hiding this comment.
Got it. Should this always be ignored? Or should we also commit this folder on releases?
| !**/ImplementationFromDafny-go/**/*extern* | ||
| # ... except for go.mod ... | ||
| !**/ImplementationFromDafny-go/**/go.mod |
There was a problem hiding this comment.
For Kms and Ddb, we also generate shim.go . But not sure if we want include the shims for other projects (I think we should).
There was a problem hiding this comment.
Do you mean the wrapped shims for testing local services? I think we commit those. (But we haven't released one yet, since the only place we've committed this is in MPL test vectors, which we've never released.)
If those are also just called shim.go, I'll add shim.go to this section
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
| # Only proceed if the line is not empty | ||
| if [[ -n "$line" ]]; then | ||
| # If `git add` doesn't match any files, it errors. | ||
| # Swallow error. Release technician should detect issue. |
There was a problem hiding this comment.
Sorry, but this comment confused me.
How will the release technician detect an issue if the error is swallowed?
I guess what you are telling me is that this runs before or after some test
that ensures all the critical files are present;
that test's error is not swallowed.
There was a problem hiding this comment.
|
@lucasmcdonald3 and @texastony, I noticed you are updating the smithy model files. |
|
@lucasmcdonald3 and @lucasmcdonald3, I noticed you are updating the smithy model files. |
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
Creates a collection of files that are in
.gitignore, but force-added for releases.As part of release,
semantic_releasewill rungit_add_gitignore_bypass_release_files.shto force add these files.As part of the "allow local testing" commit, the release technician will run
remove_gitignore_bypass_release_filesto remove these files. (This is pending an MCM template update. I won't merge this PR until the MCM update is in, but would like to get approval on this PR before merging the MCM update.)(I don't like the name "release-only 'gitignore bypass'" files, so reviewers should let me know if they have suggestions.)
Testing
make run_semantic_release, it added the ignored files: linksh scripts/release/remove_gitignore_bypass_release_files.sh, it removed these files linkBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.