Fix issue with primary ENI ip lookup when an ENI has both IPv4 and IPv6 Address Assigned. #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fixes a regression introduced in this #3122
Previously we assumed the ENI (primary ENI) always will have an IPV4 and went with getting the IPv4 address.
Primary ENI will always have an IPV4 address.
However, when #3122 was introduced, we are checking ipv4Available explicitly. The way in which the ipv4 or ipv6 is checked in based on the value of IMDS metadata on MAC. It dependent on the order in which IMDS returned the value - due to using a break condition.
https://github.com/aws/amazon-vpc-cni-k8s/pull/3122/files#r1889412276
The break condition is removed and this is fixed.*
Added unit-test to catch this issue. Without the change in
awsutils.gothe unit test will fail.