Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release-1.19.1 - Revert #3122 #3157

Merged

Conversation

orsenthil
Copy link
Member

This PR reverts #3122 for release of 1.19.1 which is in progress.

 1175  git revert 7b46f6bff35f006bb4a4384138ca19d09be4e2a3
 1176  # update CHANGELOG.md
 1180  git commit -m "Update Changelog to reflect on revert of #3122"

An issue with VPC CNI 1.19.1 was caught in internal CI.

Cluster was created with IPV6 Address always assigned - https://github.com/aws/aws-k8s-tester/blob/c6bee21d2bbc2756f4a91bb5bc68495d2533b323/kubetest2/internal/deployers/eksapi/templates/infra.yaml#L289

IPAMD Initialization failed with this log message.

{"level":"debug","ts":"2024-12-17T15:40:40.867Z","caller":"awsutils/awsutils.go:1325","msg":"Total number of interfaces found: 1 "}
{"level":"debug","ts":"2024-12-17T15:40:40.867Z","caller":"awsutils/awsutils.go:567","msg":"Found ENI MAC address: 02:72:68:d4:0c:a7"}
{"level":"debug","ts":"2024-12-17T15:40:40.869Z","caller":"awsutils/awsutils.go:567","msg":"Found ENI: eni-0b1edf4cf07ae1f95, MAC 02:72:68:d4:0c:a7, device 0"}
{"level":"debug","ts":"2024-12-17T15:40:40.870Z","caller":"awsutils/awsutils.go:567","msg":"Found IPv6 addresses associated with interface. This is not efa-only interface"}
{"level":"info","ts":"2024-12-17T15:40:41.010Z","caller":"ipamd/ipamd.go:424","msg":"Got network card index 0 for ENI eni-0b1edf4cf07ae1f95"}
{"level":"info","ts":"2024-12-17T15:40:41.010Z","caller":"ipamd/ipamd.go:424","msg":"eni-0b1edf4cf07ae1f95 is of type: interface"}
{"level":"error","ts":"2024-12-17T15:40:41.010Z","caller":"ipamd/ipamd.go:424","msg":"Missing IP addresses from IMDS. Non efa-only interface should have IP address associated with it eni-0b1edf4cf07ae1f95"}
{"level":"error","ts":"2024-12-17T15:40:41.010Z","caller":"aws-k8s-agent/main.go:42","msg":"Initialization failure: ipamd init: failed to retrieve attached ENIs info: DescribeAllENIs: No IPv4 and IPv6 addresses found"}

This is due to change we brought in
Fix issues with handling unmanaged ENIs with IPv6 only - #3122

Previously we assumed the ENI (primary ENI) always will have an IPV4 and went with getting the IPv4 address. Primary ENI will always have an IPV4 address. However, when #3122 was introduced, we are checking ipv4Available explicitly. The way in which the ipv4 or ipv6 is checked in based on the value of IMDS metadata on MAC, dependent on the order in which IMDS returned the value due to using a break condition introduced here - https://github.com/aws/amazon-vpc-cni-k8s/pull/3047/files . So, when both IPv6 and IPv4 were assigned on interface, it tried to pick up IPv6 address even when the cluster was not IPV6.

Fix in the master is in review here - #3156

@orsenthil orsenthil requested a review from a team as a code owner December 18, 2024 04:05
Copy link
Contributor

@Pavani-Panakanti Pavani-Panakanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orsenthil orsenthil merged commit 1369478 into aws:release-1.19 Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants