[CELEBORN-1800] Introduce ApplicationTotalCount and ApplicationFallbackCount metric to record the total and fallback count of application #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
CELEBORN-1800
branch
3 times, most recently
from
f3126d4 to
95503c3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3026 +/- ##
==========================================
- Coverage 32.99% 32.66% -0.33%
==========================================
Files 331 336 +5
Lines 19842 20042 +200
Branches 1787 1792 +5
==========================================
- Hits 6545 6544 -1
- Misses 12933 13134 +201
Partials 364 364 ☔ View full report in Codecov by Sentry. |
SteNicholas
force-pushed
the
CELEBORN-1800
branch
from
95503c3 to
8eb3bde
Compare
…ckCount metric to record the total and fallback count of application
SteNicholas
force-pushed
the
CELEBORN-1800
branch
from
8eb3bde to
4d40188
Compare
|
Ping @turboFei, @codenohup, @reswqa, @FMX. |
turboFei
reviewed
Dec 24, 2024
turboFei
reviewed
Dec 24, 2024
turboFei
reviewed
Dec 24, 2024
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java
Show resolved
Hide resolved
…ckCount metric to record the total and fallback count of application
codenohup
reviewed
Dec 25, 2024
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleMaster.java
Outdated
Show resolved
Hide resolved
…ckCount metric to record the total and fallback count of application
SteNicholas
force-pushed
the
CELEBORN-1800
branch
from
e698224 to
c8fd052
Compare
reswqa
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce
ApplicationTotalCountandApplicationFallbackCountmetric to record the total and fallback count of application.Why are the changes needed?
There is no any metric to record the total count of application running with celeborn shuffle and engine bulit-in shuffle and the fallback count of application. Meanwhile, the fallback of Flink shuffle is based on job granularity rather than shuffle granularity.
Follw up #3012 (comment).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
DefaultMetaSystemSuiteJ#testShuffleAndApplicationCountWithFallbackRatisMasterStatusSystemSuiteJ#testShuffleAndApplicationCountWithFallback