Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1793] Add netty pinned memory metrics #3019

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leixm
Copy link
Contributor

@leixm leixm commented Dec 20, 2024

What changes were proposed in this pull request?

Add netty pinned memory metrics

Why are the changes needed?

We can know more accurately the memory actually allocated from PoolArena.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing uts.

"x": 0,
"y": 39
},
"id": 226,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI:
The ids used in #2990 are 226-233.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If #2990 merged, need to change the ids

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leixm could you rebase the ids? start from 234.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: the ids used in #3026 are 234-235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants