Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Ruby 3.3 #205

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Support for Ruby 3.3 #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f1794b2
update dependencies versions to support `3.3`
Geromendez135 Jul 16, 2024
95b7a6f
fix error from `rubocop 1.48`
Geromendez135 Jul 16, 2024
9c879dc
let`rubocop` version be `>= 1.61.0`
Geromendez135 Jul 16, 2024
0c794bb
fix `deprecation warning`
Geromendez135 Jul 16, 2024
3e84360
add `ruby 3.3` to the CI matrix
Geromendez135 Jul 16, 2024
0749e36
maintain major `rubocop` version
Geromendez135 Jul 19, 2024
d3b6074
update `setup-ruby` commit sha
Geromendez135 Jul 19, 2024
188c691
drop support for `Ruby 2.6`
Geromendez135 Jul 19, 2024
5a11e1a
allow for more flexibility on minor versions.
Geromendez135 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/rspec_rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ jobs:
strategy:
matrix:
include: # use bundler 2.3 for ruby versions < 2.6 (https://bundler.io/compatibility.html)
- ruby-version: '2.6'
bundler-version: latest
- ruby-version: '2.7'
bundler-version: latest
- ruby-version: '3.0'
bundler-version: latest
- ruby-version: '3.1'
bundler-version: latest
- ruby-version: '3.3'
bundler-version: latest
steps:
- uses: actions/checkout@v3
- name: Set up Ruby
uses: ruby/setup-ruby@ee2113536afb7f793eed4ce60e8d3b26db912da4 # v1.127.0
uses: ruby/setup-ruby@2a9a743e19810b9f3c38060637daf594dbd7b37f # 1.186.0
with:
ruby-version: ${{ matrix.ruby-version }}
bundler: ${{ matrix.bundler-version }}
Expand Down
4 changes: 2 additions & 2 deletions rubocop-airbnb/config/rubocop-style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ Style/BlockDelimiters:
- let!
- subject
- watch
IgnoredMethods:
AllowedMethods:
# Methods that can be either procedural or functional and cannot be
# categorised from their usage alone, e.g.
#
Expand Down Expand Up @@ -889,7 +889,7 @@ Style/SymbolLiteral:
Style/SymbolProc:
Description: Use symbols as procs instead of blocks when possible.
Enabled: false
IgnoredMethods:
AllowedMethods:
- respond_to

Style/TernaryParentheses:
Expand Down
10 changes: 5 additions & 5 deletions rubocop-airbnb/rubocop-airbnb.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
spec.license = 'MIT'
spec.version = RuboCop::Airbnb::VERSION
spec.platform = Gem::Platform::RUBY
spec.required_ruby_version = '>= 2.5'
spec.required_ruby_version = '>= 2.7'

spec.require_paths = ['lib']
spec.files = Dir[
Expand All @@ -25,9 +25,9 @@ Gem::Specification.new do |spec|
'Gemfile',
]

spec.add_dependency('rubocop', '~> 1.32.0')
spec.add_dependency('rubocop-performance', '~> 1.10.2')
spec.add_dependency('rubocop-rails', '~> 2.9.1')
spec.add_dependency('rubocop-rspec', '~> 2.0.0')
spec.add_dependency('rubocop', '~> 1.61')
spec.add_dependency('rubocop-performance', '~> 1.20')
spec.add_dependency('rubocop-rails', '~> 2.24')
spec.add_dependency('rubocop-rspec', '~> 2.26')
spec.add_development_dependency('rspec', '~> 3.5')
end
Loading