Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ruby 3.3 #205

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Conversation

Geromendez135
Copy link
Contributor

@Geromendez135 Geromendez135 commented Jul 16, 2024

Add support for Ruby 3.3

Found that rubocop-airbnb requires rubocop 1.32.0 which only supports up to Ruby 3.2, See here.
This is the commit that adds support for 3.3 starting from version 1.46.0.

Summary

  • Update rubocop version to support Ruby 3.3
  • Constrain rubocop version to be >= 1.61.0
  • Fixed some deprecations
  • Added Ruby 3.3 to the CI matrix

Test

  • Ran tests locally.

error from said version of rubocop:
RuboCop::ValidationError:
  Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not.

version `1.61` of `rubocop` fixes that issue, allowing all tests to pass.

found that solution in this issue:
rubocop/rubocop-rspec#1916
from rubocop-rspec, where they were experiencing the same
error and updating rubocop to 1.61, solved the issue.
However they don't appear to know the culprit of this.
Warning: obsolete parameter `IgnoredMethods` (for `Style/BlockDelimiters`) found in config/rubocop-style.yml
`IgnoredMethods` has been renamed to `AllowedMethods` and/or `AllowedPatterns`.

parameter `IgnoredMethods` was deprecated in version
`1.33.0` of `rubocop` in favor of `AllowedMethods`. See:
https://github.com/rubocop/rubocop/blob/master/relnotes/v1.33.0.md?plain=1#L19
@Umofomia
Copy link
Contributor

Umofomia commented Jul 19, 2024

It looks like the new workflow for 3.3 is failing because the ruby/setup-ruby snapshot that's being used doesn't have 3.3 support. You'll need to update the following to a newer snapshot of ruby/setup-ruby that has the support:

uses: ruby/setup-ruby@ee2113536afb7f793eed4ce60e8d3b26db912da4 # v1.127.0

@Geromendez135
Copy link
Contributor Author

@Umofomia, just updated the setup-ruby snapshot to v1 let me know whether I should use a specific commit sha or that's OK.

@Umofomia
Copy link
Contributor

let me know whether I should use a specific commit sha or that's OK.

I'm fine with using @v1, though wondering if @pariser would like to comment here since he originally introduced the specific commit. The ruby/setup-ruby documentation mentions preferring @v1 anyway, though I can see how a specific commit can be more deterministic.

@Geromendez135
Copy link
Contributor Author

I see it failed for 2.6 because of this breaking change on rubocop-performance
should we remove 2.6 from the tests?

@Umofomia
Copy link
Contributor

It looks like the updates to the dependencies now require Ruby 2.7, so the Ruby 2.6 tests are now failing. We can probably drop support for Ruby 2.6 anyway going forward, so go ahead and remove the 2.6 tests from the matrix:

- ruby-version: '2.6'
bundler-version: latest

I would also update the line here to indicate that the gem itself only supports 2.7 and higher:

spec.required_ruby_version = '>= 2.5'

Copy link
Contributor

@Umofomia Umofomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for making the change to add support for Ruby 3.3 to the rubocop-airbnb gem.

Copy link
Contributor

@pariser pariser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has:

  • increased the minimum rubocop version to ~> 1.61 (from ~> 1.32.0)
  • dropped support for ruby 2.6
  • added support for ruby 3.3

This has not:

  • changed any of the rubocop rule configurations

Thank you!

@pariser pariser merged commit e62bb1d into airbnb:main Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants