Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(HMS-1947): Parameterize post-deploy tests for both stage and prod #585

Merged
merged 1 commit into from
Jul 7, 2023
Merged

ci(HMS-1947): Parameterize post-deploy tests for both stage and prod #585

merged 1 commit into from
Jul 7, 2023

Conversation

tpapaioa
Copy link
Member

@tpapaioa tpapaioa commented Jul 6, 2023

In preparation for adding prod post-deploy tests, this PR parameterizes the post-deploy test template to support both stage and prod environments. Currently the only parameters are the dynaconf environment and the pytest marker expression used by pytest to determine both the environment and the tests to run against it.


Thanks for the contribution, make sure your commit message follows this subject style:

    type: brief summary up to 70 characters or
    type(scope): brief summary up to 70 characters

Type is required, scope is optional. Prefer lower-case and avoid dot at the end.

Find more info about types and scopes at:

https://github.com/RHEnVision/provisioning-backend#contributing

Take a moment to read our contributing and security guidelines:

https://github.com/RedHatInsights/secure-coding-checklist

Checklist

  • all commit messages follows the policy above
  • the change follows our security guidelines

@tpapaioa tpapaioa changed the title ci(HMS-1947): Parameterize post-deploy test template to allow both stage and prod ci(HMS-1947): Parameterize post-deploy tests for both stage and prod Jul 6, 2023
@tpapaioa tpapaioa requested a review from mshriver July 6, 2023 17:36
@mshriver
Copy link
Member

mshriver commented Jul 7, 2023

/retest

@mshriver
Copy link
Member

mshriver commented Jul 7, 2023

The bonfire deploy failed via timeout in the pr check, CJI template looks fine (and isn't even used by pr check)

@mshriver mshriver merged commit 4a828ea into RHEnVision:main Jul 7, 2023
7 checks passed
@tpapaioa tpapaioa deleted the parameterize_test_template branch July 7, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants