Fixes #282 - project detection in dashboard #284
Conversation
…file only new sample project for testing server.xml Added test case for detect project with src/main/liberty/config/server.xml file only
…ection_integrationTest
src/test/utils/testUtils.ts
Outdated
| console.log("items...."+(items.length === 0)); | ||
| return items.length === 0; | ||
| } catch (error) { | ||
| // if there is no visible elements, getVisibleItems() method is throwing timeout error. |
There was a problem hiding this comment.
do we know for sure that is the only error that would occur here? Is it possible other errors may occur that would not be an indication of the view section being empty?
There was a problem hiding this comment.
@TrevCraw - I have added a check whether the error is a kind of timeout error. Ideally the items.length should be 0, if the view section is empty. But the test framework is waiting for the view section to load some text and finally throwing timeout error. I have tried several solutions to get the count as 0, but test framework is always throwing the timeout exception.
There was a problem hiding this comment.
Does the timeout exception have a specific error code or message with it?
There was a problem hiding this comment.
@TrevCraw - No, always throwing timeout exception.
Co-authored-by: Trevor Crawford <[email protected]>
Co-authored-by: Trevor Crawford <[email protected]>
Co-authored-by: Trevor Crawford <[email protected]>
Co-authored-by: Trevor Crawford <[email protected]>
Co-authored-by: Trevor Crawford <[email protected]>
Co-authored-by: Trevor Crawford <[email protected]>
Added a condition in catch block to confirm the error is Timeouterror.
|
@TrevCraw - I have formatted the files. |
…ection_integrationTest
aparnamichael
requested review from
vaisakhkannan
and removed request for
TrevCraw,
vaisakhkannan and
anusreelakshmi934
Fixes #282 - Added test case to detect project with src/main/liberty/config/server.xml file only (ie. no LMP or LGP defined in build file)