Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for project detection #282

Open
5 tasks done
TrevCraw opened this issue Aug 7, 2023 · 2 comments · May be fixed by #284
Open
5 tasks done

Add tests for project detection #282

TrevCraw opened this issue Aug 7, 2023 · 2 comments · May be fixed by #284
Assignees

Comments

@TrevCraw
Copy link
Contributor

TrevCraw commented Aug 7, 2023

  • detect project with src/main/liberty/config/server.xml file only (ie. no LMP or LGP defined in build file)
  • detect project with LMP config in build file only (ie. no server.xml in project)
  • detect project with LGP config in build file only (ie. no server.xml in project)

Example tests in LT IntelliJ:
https://github.com/OpenLiberty/liberty-tools-intellij/blob/main/src/test/java/io/openliberty/tools/intellij/it/SingleModNLTRestProjectTestCommon.java#L110-L214

@aparnamichael
Copy link
Contributor

aparnamichael commented Aug 30, 2023

Added test cases to detect project with src/main/liberty/config/server.xml file only (ie. no LMP or LGP defined in build file)
PR - #284

@TrevCraw TrevCraw linked a pull request Aug 30, 2023 that will close this issue
@aparnamichael
Copy link
Contributor

aparnamichael commented Apr 30, 2024

This PR has to update with the latest changes. Also waiting to merge #328.

After that re-review is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants