Skip to content
This repository has been archived by the owner on Dec 17, 2020. It is now read-only.

[WIP] Test hip nvidia #29

Draft
wants to merge 39 commits into
base: hip_rebased
Choose a base branch
from
Draft

[WIP] Test hip nvidia #29

wants to merge 39 commits into from

Commits on Feb 7, 2020

  1. Remove C++11 workarounds

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    72ad2e5 View commit details
    Browse the repository at this point in the history

  2. remove bool_, int_, unsigned_

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    8a1ccd9 View commit details
    Browse the repository at this point in the history

  3. Use nullptr

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    53c46ae View commit details
    Browse the repository at this point in the history

  4. Use nullptr at some more places

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    9beeb98 View commit details
    Browse the repository at this point in the history

  5. Provide policies with space() member function

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    edb31ee View commit details
    Browse the repository at this point in the history

  6. Execution space fences in containers

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    35d0418 View commit details
    Browse the repository at this point in the history

  7. Use space() in Kokkos_Parallel.hpp

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    1560f6d View commit details
    Browse the repository at this point in the history

  8. Use execution space instance in Kokkos_Parallel_Reduce.hpp

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    e54760a View commit details
    Browse the repository at this point in the history

  9. Fix a typo

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    ec7743c View commit details
    Browse the repository at this point in the history

  10. Disable stacktrace unit tests when Trilinos is enabled

    @ndellingwood @masterleinad
    ndellingwood authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    a06e0dc View commit details
    Browse the repository at this point in the history

  11. Add free functions reallocate() and resize() for dual views

    @masterleinad
    David Hollman authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    1bf590f View commit details
    Browse the repository at this point in the history

  12. Adding unit test for DualView resize and reallocate through non-membe… 

    …r functions
    @masterleinad
    Jan Ciesko (-EXP) authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    552b29e View commit details
    Browse the repository at this point in the history

  13. Changed DualView realloc and resize signatures params to by-reference

    @masterleinad
    Jan Ciesko (-EXP) authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    e2c8714 View commit details
    Browse the repository at this point in the history

  14. Remove unnecessary cast to rvalue reference in resize() and reallocat… 

    …e() for dual views
    @dalg24 @masterleinad
    dalg24 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    e6db520 View commit details
    Browse the repository at this point in the history

  15. Fix comment in TestDualView.hpp 

    Co-Authored-By: Damien L-G <[email protected]>
    @dalg24 @masterleinad
    2 people authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    e5f721b View commit details
    Browse the repository at this point in the history

  16. Fixup {/*unqualified*/, std::}is_same

    @dalg24 @masterleinad
    dalg24 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    f63f92c View commit details
    Browse the repository at this point in the history

  17. fix add_executable for examples/tests

    @masterleinad
    jjwilke authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    0f5947f View commit details
    Browse the repository at this point in the history

  18. Add option to turn off/on alignment of Kokkos::complex

    @crtrott @masterleinad
    crtrott authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    3a07b32 View commit details
    Browse the repository at this point in the history

  19. Enable more tests for HIP

    @Rombur @masterleinad
    Rombur authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    3ca62aa View commit details
    Browse the repository at this point in the history

  20. Fix compiling the examples

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    93c13a6 View commit details
    Browse the repository at this point in the history

  21. Clean example/tutorial a bit; remove example/cmake/Dependencies.cmake

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    13b1c27 View commit details
    Browse the repository at this point in the history

  22. Remove uvm allocation limit

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    103754d View commit details
    Browse the repository at this point in the history

  23. Add missing -Xcompiler flags for OpenMP 

    Matching PR to fix provided by @jjwilke in Trilinos
trilinos/Trilinos#6700
    @ndellingwood @masterleinad
    ndellingwood authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    dcbd42a View commit details
    Browse the repository at this point in the history

  24. Deprecate CudaUVMSpace::number_of_allocations()

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    59e3acb View commit details
    Browse the repository at this point in the history

  25. Improve TPL header and library search 

    Testing of TPL imports with clang revealed the following issues:

1. <TPL>_ROOT variables could be specified as command line options,
   e.g. `cmake -D<TPL>_ROOT=/path/to/tpl ..`, but not as environment
   variables, e.g. `<TPL>_ROOT=/path/to/tpl cmake ..`. This differs
   from standard find_package/find_library behavior and can be confusing
   when TPL search fails.

2. kokkos_find_library and kokkos_find_header were using <NAME>_FOUND
   to bypass multiple searches, however, the CMAKE functions find_library
   and find_path do not set this variable. Replaced with checking of
   <NAME>_LOCATION directly (further refactor possible).

3. The set of possible suffixes for <TPL>_ROOT, KOKKOS_<TPL>_DIR, etc.
   was not sufficent to locate libcuda in the "CUDA_ROOT/lib64/stubs"
   subdirectory. This non-functional libcuda is important for cross-
   compiling when the device driver is not installed on the host
   machine (e.g. cluster login node)
    @jphill4 @masterleinad
    jphill4 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    79055eb View commit details
    Browse the repository at this point in the history

  26. Refactor kokkos_find_{library,header} to reduce redundant conditionals 

    Refactored these routines using the fact that (1) CMake will silently
expand un-set variables to the empty string (2) PATHS to find_library
and find_path are searched in order provided (3) if the output variable
is set to something other than <VAR>-NOTFOUND, calls to find_library
and find_path will do nothing (output variable must be cleared).
    @jphill4 @masterleinad
    jphill4 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    c499162 View commit details
    Browse the repository at this point in the history

  27. Make library search suffixes configurable via macro argument. 

    Kokkos team requested that lib/stubs, lib64/stubs library
search suffixes be added to the suffix list only when searching
for CUDA. This commit adds options to kokkos_find_imported and
kokkos_find_library to allow the library search suffixes to be
set by the caller. It also updates FindTPLCUDA to use this
feature to add the stub directories to the search list.
    @jphill4 @masterleinad
    jphill4 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    df45ba4 View commit details
    Browse the repository at this point in the history

  28. Remove redundant semicolons

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    538829e View commit details
    Browse the repository at this point in the history

  29. Bracket CUDA-Trilinos flags with ENABLE_CUDA

    @masterleinad
    jjwilke authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    858db33 View commit details
    Browse the repository at this point in the history

  30. Fix more redundant semicolons

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    99b8696 View commit details
    Browse the repository at this point in the history

  31. Fix OpenMPTarget build

    @crtrott @masterleinad
    crtrott authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    d84731d View commit details
    Browse the repository at this point in the history

  32. Pointless change nVidia -> NVIDIA in a comment

    @dalg24 @masterleinad
    dalg24 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    b8d593b View commit details
    Browse the repository at this point in the history

  33. Add /usr/local/cuda to the paths searched with Clang

    @dalg24 @masterleinad
    dalg24 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    7cb5105 View commit details
    Browse the repository at this point in the history

  34. Remove the workaround to find libcudart in the Docker image for the C… 

    …lang build on Jenkins
    @dalg24 @masterleinad
    dalg24 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    1ee295b View commit details
    Browse the repository at this point in the history

  35. Make Kokkos::fence() fence all execution spaces

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    33fd81e View commit details
    Browse the repository at this point in the history

  36. Move cmd line and env args parsing to separate functions

    @dalg24 @masterleinad
    dalg24 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    0180dfb View commit details
    Browse the repository at this point in the history

  37. Honor environment variables as well when initilializing from InitArgu… 

    …ments
    @dalg24 @masterleinad
    dalg24 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    7f46a91 View commit details
    Browse the repository at this point in the history

  38. Fixup let initialize() take InitArguments by value

    @dalg24 @masterleinad
    dalg24 authored and masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    49b67f3 View commit details
    Browse the repository at this point in the history

  39. Test HIP through Nvidia

    @masterleinad
    masterleinad committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    26b3683 View commit details
    Browse the repository at this point in the history