This repository has been archived by the owner on Dec 17, 2020. It is now read-only.
[WIP] Test hip nvidia #29
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e() for dual views
Co-Authored-By: Damien L-G <[email protected]>
Matching PR to fix provided by @jjwilke in Trilinos trilinos/Trilinos#6700
Testing of TPL imports with clang revealed the following issues: 1. <TPL>_ROOT variables could be specified as command line options, e.g. `cmake -D<TPL>_ROOT=/path/to/tpl ..`, but not as environment variables, e.g. `<TPL>_ROOT=/path/to/tpl cmake ..`. This differs from standard find_package/find_library behavior and can be confusing when TPL search fails. 2. kokkos_find_library and kokkos_find_header were using <NAME>_FOUND to bypass multiple searches, however, the CMAKE functions find_library and find_path do not set this variable. Replaced with checking of <NAME>_LOCATION directly (further refactor possible). 3. The set of possible suffixes for <TPL>_ROOT, KOKKOS_<TPL>_DIR, etc. was not sufficent to locate libcuda in the "CUDA_ROOT/lib64/stubs" subdirectory. This non-functional libcuda is important for cross- compiling when the device driver is not installed on the host machine (e.g. cluster login node)
Refactored these routines using the fact that (1) CMake will silently expand un-set variables to the empty string (2) PATHS to find_library and find_path are searched in order provided (3) if the output variable is set to something other than <VAR>-NOTFOUND, calls to find_library and find_path will do nothing (output variable must be cleared).
Kokkos team requested that lib/stubs, lib64/stubs library search suffixes be added to the suffix list only when searching for CUDA. This commit adds options to kokkos_find_imported and kokkos_find_library to allow the library search suffixes to be set by the caller. It also updates FindTPLCUDA to use this feature to add the stub directories to the search list.
…lang build on Jenkins
masterleinad
force-pushed
the
test_hip_nvidia
branch
from
515df7f
to
26b3683
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.