Simple cardano-client subscriber & mux changes #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/simple-subscriber
branch
from
6528d2d
to
9baacd0
Compare
This was
linked to
issues
Oct 2, 2024
coot
force-pushed
the
coot/simple-subscriber
branch
from
9baacd0
to
deadd0f
Compare
coot
force-pushed
the
coot/simple-subscriber
branch
2 times, most recently
from
26490be
to
aaf5624
Compare
coot
force-pushed
the
coot/simple-subscriber
branch
from
aaf5624
to
a19fc6e
Compare
bolt12
approved these changes
Oct 8, 2024
Expose `connectTo` version which accepts a callback that has access to `Mux`. This allows to implement ones own logic for: * starting approriate mini-protocols (one doesn't need to start all of them). * implement ones own restarting policy for `mini-protocols`, without terminating a connection.
* added `ConnectToArgs` * `connectToNode` and friends return the result of the first terminated mini-protocol (or its error)
Provide a `Channel` which can send arbitrary data. This is useful if one wants to test application with or without the multiplexer. For us this simplifies `Ouroboros.Network.Channel` module in the `ouroboros-network-framework` package.
It is used to name various shared stm variables. NOTE: we name them when we `runMux`, not when `newMux` is created.
coot
force-pushed
the
coot/simple-subscriber
branch
from
e156890
to
6d95a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
connectToNodeWithMux& friendsRequires:
Removed Network.Mux.Compat module #4974
node-to-client: expose connectToWithMux
ouroboros-network-framework: added ConnectToArgs record
cardano-client: subscription without subscribtion worker
network-mux: generalised Channel type
Updated CHANGELOG.md files
network-mux: added name field to MuxBearer
Checklist
Quality
Maintenance
ouroboros-networkproject.