Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up Network.Mux.Channel #4336

Open
coot opened this issue Feb 3, 2023 · 0 comments · May be fixed by #4979
Open

Clean-up Network.Mux.Channel #4336

coot opened this issue Feb 3, 2023 · 0 comments · May be fixed by #4979
Assignees
Labels
mux issues related to network-mux technical debt

Comments

@coot
Copy link
Contributor

coot commented Feb 3, 2023

We have Network.Mux.Channel and Ouroboros.Network.Channel which do not differ much. Network.Mux.Channel.Channel m = Ouroboros.Network.Channel.Channel m ByteString. My short experiment suggests that:

  • we can remove all auxiliary functions from Network.Mux.Channel they are not
    used by network-mux package at all.
  • there's just one place where one of the Network.Mux.Channel functions is
    used in Ouroboros.Network.Channel and it can be replaced
  • we could either move the network-mux Channel entirely to
    Network.Mux.Types or make it an internal module. We should instead expose
    the type from Network.Mux or Network.Mux.Types as it's part of essential
    public API.

Furthermore we should consider to move the auxiliary functions of
Ouroboros.Network.Channel to ouroboros-network-testing: I suspect they are
only used in various demos & tests.

@coot coot added mux issues related to network-mux networking technical debt labels Feb 3, 2023
@coot coot removed the networking label Dec 18, 2023
@coot coot self-assigned this Oct 2, 2024
@coot coot linked a pull request Oct 2, 2024 that will close this issue
8 tasks
@coot coot linked a pull request Oct 2, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mux issues related to network-mux technical debt
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant