Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom _add_slots decorator with dataclasses slots=True #1113

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Replace custom _add_slots decorator with dataclasses slots=True

2feb8ea
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Replace custom _add_slots decorator with dataclasses slots=True #1113

Replace custom _add_slots decorator with dataclasses slots=True
2feb8ea
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Mar 3, 2024 in 3s

clippy

203 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 203
Note 0
Help 0

Versions

  • rustc 1.76.0 (07dca489a 2024-02-04)
  • cargo 1.76.0 (c84b36747 2024-01-18)
  • clippy 0.1.76 (07dca489 2024-02-04)

Annotations

Check warning on line 29 in libcst/src/bin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `print!` args

warning: `to_string` applied to a type that implements `Display` in `print!` args
  --> libcst/src/bin.rs:29:35
   |
29 |                 print!("{}", state.to_string());
   |                                   ^^^^^^^^^^^^ help: remove this
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
   = note: `#[warn(clippy::to_string_in_format_args)]` on by default

Check warning on line 22 in libcst/src/bin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `unwrap_or_else` to construct default value

warning: use of `unwrap_or_else` to construct default value
  --> libcst/src/bin.rs:22:48
   |
22 |             let first_arg = env::args().nth(1).unwrap_or_else(|| "".to_string());
   |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
   = note: `#[warn(clippy::unwrap_or_default)]` on by default

Check warning on line 3435 in libcst/src/parser/grammar.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of `Option::map`

warning: manual implementation of `Option::map`
    --> libcst/src/parser/grammar.rs:3431:24
     |
3431 |       let lbracket_tok = if let Some(tp) = &type_parameters {
     |  ________________________^
3432 | |         Some(tp.lbracket.tok)
3433 | |     } else {
3434 | |         None
3435 | |     };
     | |_____^ help: try: `type_parameters.as_ref().map(|tp| tp.lbracket.tok)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
     = note: `#[warn(clippy::manual_map)]` on by default

Check warning on line 1888 in libcst/src/parser/grammar.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
    --> libcst/src/parser/grammar.rs:1888:25
     |
1888 |     a.into_iter().chain(b.into_iter()).collect()
     |                         ^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `b`
     |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
    --> /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/iter/traits/iterator.rs:524:12
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
     = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 81 in libcst/src/parser/errors.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this lifetime isn't used in the impl

warning: this lifetime isn't used in the impl
  --> libcst/src/parser/errors.rs:81:10
   |
81 |     impl<'a> PyErrArguments for Details {
   |          ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
   = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default

Check warning on line 63 in libcst/src/nodes/module.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
  --> libcst/src/nodes/module.rs:63:18
   |
63 |             &mut (*self.eof_tok).whitespace_before.borrow_mut(),
   |                  ^^^^^^^^^^^^^^^ help: try: `self.eof_tok`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1415 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1415:18
     |
1415 |             &mut (*self.tok).whitespace_after.borrow_mut(),
     |                  ^^^^^^^^^^^ help: try: `self.tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1411 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1411:18
     |
1411 |             &mut (*self.tok).whitespace_before.borrow_mut(),
     |                  ^^^^^^^^^^^ help: try: `self.tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1312 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1312:26
     |
1312 |                     &mut (*tok).whitespace_after.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1308 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1308:26
     |
1308 |                     &mut (*tok).whitespace_before.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1298 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1298:26
     |
1298 |                     &mut (*tok).whitespace_after.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1294 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1294:26
     |
1294 |                     &mut (*tok).whitespace_before.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1284 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1284:26
     |
1284 |                     &mut (*tok).whitespace_after.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1280 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1280:26
     |
1280 |                     &mut (*tok).whitespace_before.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1270 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1270:26
     |
1270 |                     &mut (*tok).whitespace_after.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1266 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1266:26
     |
1266 |                     &mut (*tok).whitespace_before.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1256 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1256:26
     |
1256 |                     &mut (*tok).whitespace_after.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1252 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1252:26
     |
1252 |                     &mut (*tok).whitespace_before.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1242 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1242:26
     |
1242 |                     &mut (*tok).whitespace_after.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1238 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1238:26
     |
1238 |                     &mut (*tok).whitespace_before.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1228 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1228:26
     |
1228 |                     &mut (*tok).whitespace_after.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1224 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1224:26
     |
1224 |                     &mut (*tok).whitespace_before.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1214 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1214:26
     |
1214 |                     &mut (*tok).whitespace_after.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1210 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1210:26
     |
1210 |                     &mut (*tok).whitespace_before.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 1200 in libcst/src/nodes/op.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
    --> libcst/src/nodes/op.rs:1200:26
     |
1200 |                     &mut (*tok).whitespace_after.borrow_mut(),
     |                          ^^^^^^ help: try: `tok`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref