Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom _add_slots decorator with dataclasses slots=True #1113

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zsol
Copy link
Member

@zsol zsol commented Mar 3, 2024

Replace custom _add_slots decorator with dataclasses slots=True

Dataclasses has a built-in slots generation feature since Python 3.10.

Dataclasses has a built-in slots generation feature since Python 3.10.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (8a19d05) to head (2feb8ea).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   91.12%   91.04%   -0.09%     
==========================================
  Files         256      254       -2     
  Lines       26578    26313     -265     
==========================================
- Hits        24220    23956     -264     
+ Misses       2358     2357       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants