-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 11 SPM Support/Release #1368
Comments
Hey @RamblinWreck77, thanks for the heads up! The team is working on cutting a new release. |
How's it going with the release? This is one of our last dependencies for our SPM conversion. |
@RamblinWreck77 Did you manage to get it working with SPM from |
@Petteri78 I haven't tried master, though just looking at it I'm blown away that it has over a year of active development past the latest release. I usually shy away from using master since I don't want some stray commit causing instability and clear cut releases make testing easier, but if this is how they're doing things I might reconsider. If they don't want to periodically cut releases once a quarter or so why bother supporting this (awesome) library in the first place? |
I think the new IGListDiffKit change also needs to be added to SPM |
@danqing good call-out, this is something we'll need to make sure SPM can handle the changes with splitting IGListKit and IGListDiffKit |
Now that 4.0 is out, can this be revisited? I had a crack at setting up the Package.swift but it was out of my depth. |
@nick-potts Totally, we would prioritize to fix the SPM integration here, thanks for raising this! |
Any news? |
Any News? |
The issue appears to be that the |
All that is needed to be done is to update the import declarations in some files. it's not that hard and I've already done it (contribute to) a few frameworks with C/C++ dependencies. |
Any news/progress? |
I have this draft SPM setting code WIP: lorixx@81c90ae However, I hit a road blocker for the "Internal header file not found error" error, ugrrr really hate Xcode project settings and I have no idea how to proceed here. If anyone want to continue to explore, feel free to take my draft code and send a PR! |
Super exciting work @3a4oT, hope this ships soon! |
thanks, @RamblinWreck77, I think there is some workable solution now. Will appreciate any feedback from a real user :) |
any updates on this? |
Summary: ## Changes in this pull request A better version of Instagram#1465 =) - SPM support with script-based generations. - added macOS Catalyst support ### Generate SPM layout 1. From **project's root** run: `bash scripts/generate_spm_sources_layout.sh` 2. Commit Changes Repeat those steps each time you delete/add the project's files. **Make sure** to have this CI step which will check that `generate_spm_sources_layout.sh` is not broken. Issue fixed: Instagram#1368 Instagram#1406 ### Checklist - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1487 Reviewed By: candance Differential Revision: D25562739 Pulled By: lorixx fbshipit-source-id: eb4f9e82e6b4842aae71585e0c1377c13cf21196
Summary: ## Changes in this pull request A better version of Instagram#1465 =) - SPM support with script-based generations. - added macOS Catalyst support ### Generate SPM layout 1. From **project's root** run: `bash scripts/generate_spm_sources_layout.sh` 2. Commit Changes Repeat those steps each time you delete/add the project's files. **Make sure** to have this CI step which will check that `generate_spm_sources_layout.sh` is not broken. Issue fixed: Instagram#1368 Instagram#1406 ### Checklist - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1487 Differential Revision: D30428297 Pulled By: lorixx fbshipit-source-id: 7fe5e99f2c6faf695a74588743a17fcafd02de44
Hello! Now that the Xcode 11 GM is out, we're attempting to migrate from Cocoapods -> SwiftPM.
It looks like Package.swift is already on master, but there hasn't been a release that includes that commit yet.
For now, simply switching SPM to "master" resolves the issue, but would you guys be interested in pushing out a release soon that officially supports SPM?
The text was updated successfully, but these errors were encountered: