Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 11 SPM Support/Release #1368

Closed
RamblinWreck77 opened this issue Sep 13, 2019 · 18 comments
Closed

Xcode 11 SPM Support/Release #1368

RamblinWreck77 opened this issue Sep 13, 2019 · 18 comments
Milestone

Comments

@RamblinWreck77
Copy link

Hello! Now that the Xcode 11 GM is out, we're attempting to migrate from Cocoapods -> SwiftPM.

It looks like Package.swift is already on master, but there hasn't been a release that includes that commit yet.

For now, simply switching SPM to "master" resolves the issue, but would you guys be interested in pushing out a release soon that officially supports SPM?

@DimaVartanian
Copy link
Member

Hey @RamblinWreck77, thanks for the heads up! The team is working on cutting a new release.

@joeboyscout04
Copy link

How's it going with the release? This is one of our last dependencies for our SPM conversion.

@Petteri78
Copy link

@RamblinWreck77 Did you manage to get it working with SPM from master? We get import errors when compiling.

@RamblinWreck77
Copy link
Author

@Petteri78 I haven't tried master, though just looking at it I'm blown away that it has over a year of active development past the latest release. I usually shy away from using master since I don't want some stray commit causing instability and clear cut releases make testing easier, but if this is how they're doing things I might reconsider.

If they don't want to periodically cut releases once a quarter or so why bother supporting this (awesome) library in the first place?

@danqing
Copy link

danqing commented Nov 1, 2019

I think the new IGListDiffKit change also needs to be added to SPM

@Ziewvater Ziewvater added this to the 4.0.0 milestone Nov 4, 2019
@Ziewvater
Copy link

@danqing good call-out, this is something we'll need to make sure SPM can handle the changes with splitting IGListKit and IGListDiffKit

@nick-potts
Copy link

Now that 4.0 is out, can this be revisited? I had a crack at setting up the Package.swift but it was out of my depth.

@lorixx
Copy link
Contributor

lorixx commented Nov 24, 2019

@nick-potts Totally, we would prioritize to fix the SPM integration here, thanks for raising this!

@mohpor
Copy link

mohpor commented Jan 16, 2020

Any news?

@ivenprillwitz
Copy link

Any News?

@patch-benjamin
Copy link

The issue appears to be that the package.swift file doesn't include any dependency references. From my limited research on Swift PM I believe the package.swift file should include a dependency section that lists IGListDiffKit as a dependency and then make that framework also support Swift PM. Not sure if that would really fix it, but it seems like the right first step/direction.
https://swift.org/package-manager/#importing-dependencies

@mohpor
Copy link

mohpor commented Apr 4, 2020

All that is needed to be done is to update the import declarations in some files. it's not that hard and I've already done it (contribute to) a few frameworks with C/C++ dependencies.

@RamblinWreck77
Copy link
Author

Any news/progress?

@lorixx
Copy link
Contributor

lorixx commented Sep 22, 2020

I have this draft SPM setting code WIP: lorixx@81c90ae

However, I hit a road blocker for the "Internal header file not found error" error, ugrrr really hate Xcode project settings and I have no idea how to proceed here. If anyone want to continue to explore, feel free to take my draft code and send a PR!

@3a4oT
Copy link
Contributor

3a4oT commented Oct 9, 2020

@lorixx please see #1465, it took me some time to workaround bunch of limitations of SPM but I was able to make it work.

@RamblinWreck77
Copy link
Author

Super exciting work @3a4oT, hope this ships soon!

@3a4oT
Copy link
Contributor

3a4oT commented Nov 17, 2020

thanks, @RamblinWreck77, I think there is some workable solution now. Will appreciate any feedback from a real user :)

@3a4oT 3a4oT mentioned this issue Dec 14, 2020
4 tasks
@BrentMifsud
Copy link

any updates on this?

@lorixx lorixx mentioned this issue Aug 14, 2021
4 tasks
lorixx pushed a commit to lorixx/IGListKit that referenced this issue Aug 14, 2021
Summary:
## Changes in this pull request

 A better version of Instagram#1465 =)

- SPM support with script-based generations.

- added macOS Catalyst support

 ### Generate SPM layout

1. From **project's root** run:

   `bash scripts/generate_spm_sources_layout.sh`

  2. Commit Changes

 Repeat those steps each time you delete/add the project's files. **Make sure** to have this CI step which will check that `generate_spm_sources_layout.sh` is not broken.

Issue fixed: Instagram#1368 Instagram#1406

### Checklist

- [ ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)

Pull Request resolved: Instagram#1487

Reviewed By: candance

Differential Revision: D25562739

Pulled By: lorixx

fbshipit-source-id: eb4f9e82e6b4842aae71585e0c1377c13cf21196
lorixx pushed a commit to lorixx/IGListKit that referenced this issue Aug 19, 2021
Summary:
## Changes in this pull request

 A better version of Instagram#1465 =)

- SPM support with script-based generations.

- added macOS Catalyst support

 ### Generate SPM layout

1. From **project's root** run:

   `bash scripts/generate_spm_sources_layout.sh`

  2. Commit Changes

 Repeat those steps each time you delete/add the project's files. **Make sure** to have this CI step which will check that `generate_spm_sources_layout.sh` is not broken.

Issue fixed: Instagram#1368 Instagram#1406

### Checklist

- [ ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)

Pull Request resolved: Instagram#1487

Differential Revision: D30428297

Pulled By: lorixx

fbshipit-source-id: 7fe5e99f2c6faf695a74588743a17fcafd02de44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet