-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift Package Manager integration already broken (4.0.0), though it's not a pain #1406
Comments
@danqing For SwiftPM on Objective-C, it's a pain because SwiftPM design assume using the raw C style for
If you want to supports SwiftPM, you can checkout what SDWebImage do, which have also two Target (one |
@dreampiggy I note that SDWebImage use |
@Bruce-pac Use both
@import IGListKit;
import IGListKit cause the compile error showed in the first screenshot. You can have a check again at 4.0.0 version via SwiftPM. |
@dreampiggy yeah, a big reason of that is that the Package.swift manifest file is not right. I'm trying rewrite Package.swift file.
However, IGListKit use
If I modify the import style to So I guess this issue maybe has two solutions, one is like SDWebImage, other is like CocoaLumberjack. |
If you use For example, move the source code's header, as this strcture
So the SwiftPM can search this with |
Do you have an ETA on when this is gonna be released? @Bruce-pac @dreampiggy |
spm sucks, i stick with cocoapods |
OMG I had exact issue that @Bruce-pac experienced before: #1368 (comment) this is what I am trying, maybe we cannot go around the Apple's setting to require "XXX.h" format instead of <Library/XXX>h> format here. @dreampiggy interesting, I actually tried it out but I am not able to successfully build the project still. |
I'm not the maintainer of IGListKit. I'm the maintainer of SDWebImge. You can try to see how we use symbol link the header to keep the same import syntax of
Though I think these massive crazy Package Managers (first Carthage) may disappear after some years of adopting SwiftPM. |
Some work in progress #1465 |
any updates on this? |
Summary: ## Changes in this pull request A better version of Instagram#1465 =) - SPM support with script-based generations. - added macOS Catalyst support ### Generate SPM layout 1. From **project's root** run: `bash scripts/generate_spm_sources_layout.sh` 2. Commit Changes Repeat those steps each time you delete/add the project's files. **Make sure** to have this CI step which will check that `generate_spm_sources_layout.sh` is not broken. Issue fixed: Instagram#1368 Instagram#1406 ### Checklist - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1487 Reviewed By: candance Differential Revision: D25562739 Pulled By: lorixx fbshipit-source-id: eb4f9e82e6b4842aae71585e0c1377c13cf21196
Summary: ## Changes in this pull request A better version of Instagram#1465 =) - SPM support with script-based generations. - added macOS Catalyst support ### Generate SPM layout 1. From **project's root** run: `bash scripts/generate_spm_sources_layout.sh` 2. Commit Changes Repeat those steps each time you delete/add the project's files. **Make sure** to have this CI step which will check that `generate_spm_sources_layout.sh` is not broken. Issue fixed: Instagram#1368 Instagram#1406 ### Checklist - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1487 Differential Revision: D30428297 Pulled By: lorixx fbshipit-source-id: 7fe5e99f2c6faf695a74588743a17fcafd02de44
Summary: ## Changes in this pull request A better version of #1465 =) - SPM support with script-based generations. - added macOS Catalyst support ### Generate SPM layout 1. From **project's root** run: `bash scripts/generate_spm_sources_layout.sh` 2. Commit Changes Repeat those steps each time you delete/add the project's files. **Make sure** to have this CI step which will check that `generate_spm_sources_layout.sh` is not broken. Issue fixed: #1368 #1406 ### Checklist - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: #1487 Reviewed By: DimaVartanian, candance Differential Revision: D30428297 Pulled By: lorixx fbshipit-source-id: 655291ff03445dec9b0b8cd97916f0c88207e9a7
New issue checklist
README
and documentationGeneral information
IGListKit
version: 4.0.0Debug information
# Please include debug logs using the following lldb command: po [IGListDebugger dump]
Just two screenshots, enough to say the issues...
The text was updated successfully, but these errors were encountered: