SPM number10 (#1487) #1521
Closed
SPM number10 (#1487) #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Changes in this pull request A better version of Instagram#1465 =) - SPM support with script-based generations. - added macOS Catalyst support ### Generate SPM layout 1. From **project's root** run: `bash scripts/generate_spm_sources_layout.sh` 2. Commit Changes Repeat those steps each time you delete/add the project's files. **Make sure** to have this CI step which will check that `generate_spm_sources_layout.sh` is not broken. Issue fixed: Instagram#1368 Instagram#1406 ### Checklist - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1487 Reviewed By: candance Differential Revision: D25562739 Pulled By: lorixx fbshipit-source-id: eb4f9e82e6b4842aae71585e0c1377c13cf21196
|
This pull request was exported from Phabricator. Differential Revision: D25562739 |
|
@3a4oT I rebased to the latest master and tried another time to resolve all the issues for SPM. However, I am still getting some errors from the build. Feel free to piggy back on my rebase and continue the work, I think we are getting really close here! I removed some of the IGListDiff Internal files as I believe they are just a blocker for us. Test Plan:
Thanks @3a4oT ! |
|
I'll take a look in the evening or later this week! Thanks! |
|
Thanks! Feel free to update it in your original PR in #1487 ! |
|
Closing this experimental PR #1487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changes in this pull request
A better version of #1465 =)
SPM support with script-based generations.
added macOS Catalyst support
Generate SPM layout
From project's root run:
bash scripts/generate_spm_sources_layout.shCommit Changes
Repeat those steps each time you delete/add the project's files. Make sure to have this CI step which will check that
generate_spm_sources_layout.shis not broken.Issue fixed: #1368 #1406
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.Pull Request resolved: #1487
Reviewed By: candance
Differential Revision: D25562739
Pulled By: lorixx