Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build container image workflow improvements #70

Merged
merged 12 commits into from
Sep 30, 2024
Merged

Build container image workflow improvements #70

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
64788d3
Refactor approach to dependencies; add possibility to define custom c…
ppawlowski Sep 25, 2024
01cb953
Typo fix
ppawlowski Sep 25, 2024
890aea4
Typo fix
ppawlowski Sep 25, 2024
345f31a
Cleanup
ppawlowski Sep 26, 2024
f30aaa5
Remove unused `npm_registry_auth_token` secret
ppawlowski Sep 27, 2024
a82d076
Fix package version print
ppawlowski Sep 27, 2024
48dc4ed
Fix package version print
ppawlowski Sep 27, 2024
4a9fdab
Fix package version print
ppawlowski Sep 27, 2024
f48c9d6
Set default value for dependency version
ppawlowski Sep 27, 2024
8ca73a7
Set dependency version to latest if non is specified
ppawlowski Sep 27, 2024
6474df5
Fix dependency set if version not provided
ppawlowski Sep 27, 2024
68a4d71
Typo fix
ppawlowski Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions .github/workflows/build_container_image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ on:
description: 'AWS access key ID'
type: string
required: false
build_arguments:
description: 'Build arguments'
type: string
required: false
default: ''
build_context:
description: 'Path to the build context'
type: string
Expand Down Expand Up @@ -45,9 +50,6 @@ on:
type: boolean
default: false
secrets:
npm_registry_auth_token:
description: 'NPM registry authentication token'
required: false
temporary_registry_token:
description: 'GitHub token'
required: true
Expand Down Expand Up @@ -100,10 +102,15 @@ jobs:
echo "## Packages used to build image" >> $GITHUB_STEP_SUMMARY
for dependency in $(echo "${{ inputs.package_dependencies }}" | tr '\n' ' ')
do
echo "Updating $dependency to ${{ env.release_name }}"
cat package.json | jq ".dependencies[\"$dependency\"] = \"${{ env.release_name }}\"" > package.json-patched
mv package.json-patched package.json
echo "### :package: $dependency version: $(npm show $dependency dist-tags --json | jq -r '.${{ env.release_name }}')" >> $GITHUB_STEP_SUMMARY
dependency_name=$(echo $dependency | cut -d'=' -f1)
dependency_version=$(echo $dependency | cut -d'=' -f2)
if [ "$dependency_name" == "$dependency_version" ]; then
dependency_version="latest"
fi
dependency_semver=$(npm view $dependency_name dist-tags --json | jq -r --arg version "$dependency_version" '.[$version]')
echo "Setting $dependency_name to $dependency_version"
npm pkg set dependencies.$dependency_name=$dependency_semver
echo "### :package: $dependency_name version: $dependency_semver" >> $GITHUB_STEP_SUMMARY
done
cat package.json

Expand All @@ -126,8 +133,7 @@ jobs:
load: true
push: true
provenance: false
build-args: |
BUILD_TAG=${{ env.build_tag }}
build-args: ${{ inputs.build_arguments }}

- name: Scan container image for vulnerabilities
if: ${{ fromJson(inputs.scan_image) }}
Expand Down