Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build container image workflow improvements #70

Merged
merged 12 commits into from
Sep 30, 2024
Merged

Conversation

ppawlowski
Copy link
Collaborator

Description

This pull request improves Build container image reusable workflow by:

  • adding a possibility to customize docker build arguments by introducing build_arguments input
  • adding the possibility to specify dependency names together with versions
    • fallbacks to the latest version if not specified
  • simplifies the way of updating dependencies defined in package.js file

Related Issue(s)

https://github.com/FlowFuse/CloudProject/issues/389

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb merged commit c196cbb into main Sep 30, 2024
@hardillb hardillb deleted the refactor-container-build branch September 30, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants