Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database connection and plan next release #14

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

JAlvarezJarreta
Copy link
Collaborator

  • Dropped DBConnection.execute() because sqlalchemy.engine.Engine.execute() has been removed in SQLAlchemy 2.0 in favor of using a connection-oriented approach
  • Updated version planning on the new release to be made soon

@JAlvarezJarreta JAlvarezJarreta self-assigned this Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/ensembl/utils
   __init__.py50100% 
   archive.py310100% 
   argparse.py770100% 
   logging.py200100% 
   plugin.py550100% 
   rloader.py460100% 
src/ensembl/utils/database
   __init__.py30100% 
   dbconnection.py98792%214, 216, 218, 221–224
   unittestdb.py691085%94, 98, 120–121, 141, 165–168, 170
TOTAL4041795% 

Tests Skipped Failures Errors Time
68 0 💤 0 ❌ 0 🔥 1.418s ⏱️

@JAlvarezJarreta JAlvarezJarreta changed the title Update database connection and plan next library's version Update database connection and plan next release Jul 5, 2024
Copy link
Collaborator

@MatBarba MatBarba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, thanks!

@JAlvarezJarreta JAlvarezJarreta merged commit dbf2f2c into main Jul 11, 2024
5 checks passed
@JAlvarezJarreta JAlvarezJarreta deleted the jalvarez/update_dbc branch July 11, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants