Enable serial trainer for foreign protocols (Ibus/SumD)

[wimalopaan]

WIP for #1460

still limitations:

• only ibus
• missing all translations but german

[wimalopaan]

SumD not yet implemented because updated SJ receiver can output SBus.

[raphaelcoeffic]

@wimalopaan considering what has been done in #1089, we should probably revamp this code on top of main once #1089 is merged, and add a parameters to choose the protocol, don't you think? or even better, make some sort of auto-detection if possible.

[wimalopaan]

@wimalopaan considering what has been done in #1089, we should probably revamp this code on top of main once #1089 is merged, and add a parameters to choose the protocol, don't you think? or even better, make some sort of auto-detection if possible.

Yes!
First and simple, I would like to add a parameter to select the protocol SBUS or IBUS or (maybe) SumD/V3.

Is it now possible to receive the serial inverted, so that a user simply can feed in the (inverted) Sbus-Signal of some arbitrary RX with Sbus-Out?

[wimalopaan]

Actually trying to rebase this

[raphaelcoeffic]

You will have some fun, it has changed a bit ;-)

you might be luckier with just cherry-picking your commit on top of current main.

[pfeerick]

So have you noticed yet that if you power on the radio (TX16S) with either SBUS, IBUS or CRSF trainer options selected the radio locks up at the splash screen? 😁 SUMD seems to be immune to this new feature ;)

[wimalopaan]

So have you noticed yet that if you power on the radio (TX16S) with either SBUS, IBUS or CRSF trainer options selected the radio locks up at the splash screen? grin SUMD seems to be immune to this new feature ;)

Yes, I can reproduce that.
Since the IBus and SBus existed before serial rewrite, this may related to serial rewrite ...
SumD clearly is immune because it is in all cases a noop up to now.

Can you try the same with LUA-mode enabled? Does that lock up the radio too?

Thanks for testing.

[raphaelcoeffic]

Requires #1742

[wimalopaan]

Requires #1742

Can you explain that?

Will it take some time to merge #1742? If so, is there a workaround I can try?

[pfeerick]

Can you try the same with LUA-mode enabled? Does that lock up the radio too?

Do you mean as in the LUA option in the serial port menu? If so, no, that didn't lock up. It was only the SBUS, IBUS and CRSF trainer options that locked up. telemetry mirror was fine, telemetry in was fine, and I've used GPS and CLI before without issue.

For what it's worth... SBUS trainer in main (i.e. 2.7.0rc1) doesn't lockup when the SBUS trainer option is ... but I'm sure Raphael will enlighten us more as to what's happening... I'm going to bet on trying to access a timer that's not ready yet...

[wimalopaan]

I think

edgetx/radio/src/sbus.cpp

Lines 49 to 59 in 78dc293

	int sbusAuxGetByte(uint8_t* byte)
	{
	auto _getByte = _sbusAuxGetByte;
	auto _ctx = _sbusAuxGetByteCtx;
	if (_getByte) {
	return _getByte(_ctx, byte);
	}
	return -1;
	}

should return 0 or false in case being not fully initialised. -1 implicitly converts to true.

But I think the return type should be bool anyway, since this is the outcome of the FIFO, and later on that is casted from bool to int. And this function returns then -1 instead of 0 or better false in case not initialised.

I think that this is a flaw of serial rewrite and should be fixed there first ...

[wimalopaan]

The last change fixes the freeze problem at least on my radio.
This is mainly a change to serial rewrite, so maybe this should be cherry-picked to main?

[wimalopaan]

... I forgot to change the code for the taranis radios ...

[HThuren]

DA translation
add radio/translations/da.h :-)

#define TR_AUX_SERIAL_MODES "FRA\0 ""S-Port spejl\0 ""Telemetri\0 ""SBUS træner\0 ""IBUS træner\0 ""CRSF træner\0 ""SUMD træner\0 ""LUA\0 ""CLI\0 ""GPS\0 ""Debug\0 "

[Eldenroot]

CZ translation:

#define TR_AUX_SERIAL_MODES "VYP\0 ""Telemetrie zrcadlení\0 ""Telemetrie vstup\0 ""SBUS Trenér\0 ""IBUS Trenér\0 ""CRSF Trenér\0 ""SUMD Trenér\0 ""LUA\0 ""CLI\0 ""GPS\0 ""Debug\0 "

[gagarinlg]

closing, because this is replaced by #4102