Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different UART setting for SBUS on horus and taranis #1473

Closed
wimalopaan opened this issue Jan 19, 2022 · 3 comments
Closed

Different UART setting for SBUS on horus and taranis #1473

wimalopaan opened this issue Jan 19, 2022 · 3 comments

Comments

@wimalopaan
Copy link
Contributor

wimalopaan commented Jan 19, 2022 •
edited
Loading

Looking into the UART initialization code for SBUS input I found different settings:

Horus: 2 stop bits
Taranis 1 stop bit

AFAIK the 2 stop bits are correct.

(see also: #1462 )
@gagarinlg
Copy link
Member

is this still an issue?

@richardclli
Copy link
Collaborator

is this still an issue?

I do not think it is still there after @raphaelcoeffic changed the serial module API, all code should be shared now,. @wimalopaan Any comments?

@wimalopaan
Copy link
Contributor Author

I think it is fixed by the rewrite. But I did not make any checks ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@raphaelcoeffic @wimalopaan @richardclli @gagarinlg