Update dependencies #3344
Merged
Update dependencies #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
approved these changes
Sep 26, 2024
charleskawczynski
force-pushed
the
ck/up_deps
branch
from
4cd8adf
to
79cab99
Compare
charleskawczynski
force-pushed
the
ck/up_deps
branch
from
79cab99
to
82bc4c7
Compare
|
The JET failure is due to the fact that we're now unrolling the callback loop in ClimaTimeSteppers. On main, JET sees that loop and reports a single inference failure, and does not analyze inference inside each of those callbacks. With this PR, JET will now report inference on the contents of the callbacks. So, this will add a bit more friction to the adding type-unstable code in our callbacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dependencies.