Change storage dictionaries to vectors #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 84.90% 85.19% +0.29%
==========================================
Files 13 13
Lines 510 520 +10
==========================================
+ Hits 433 443 +10
Misses 77 77 ☔ View full report in Codecov by Sentry. |
charleskawczynski
force-pushed
the
ck/dict_eltypes
branch
from
45b5a62
to
32eac57
Compare
charleskawczynski
changed the title
Sbozzolo
reviewed
Sep 30, 2024
charleskawczynski
force-pushed
the
ck/dict_eltypes
branch
2 times, most recently
from
b62eac6
to
2eafeca
Compare
Sbozzolo
reviewed
Sep 30, 2024
Yeah, I'll rebase CliMA/ClimaAtmos.jl#3290 once CliMA/ClimaAtmos.jl#3344 lands and try out this branch |
|
It looks like we get a lot fewer issues with this branch, we can now see the total number of failures! 🎉 https://buildkite.com/clima/climaatmos-ci/builds/20884#019243e1-e861-408d-a36b-6d8c01abc126 |
charleskawczynski
force-pushed
the
ck/dict_eltypes
branch
from
af4812f
to
2943dd4
Compare
Update src/clima_diagnostics.jl Co-authored-by: Gabriele Bozzola <[email protected]> Bump patch version
charleskawczynski
force-pushed
the
ck/dict_eltypes
branch
from
2943dd4
to
bf389ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds and uses a new function,
concrete_dict, in an attempt to improve the type information in thestorage,accumulatorsandcountersDicts.Closes #85