Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to update alignment #136

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Add function to update alignment #136

merged 4 commits into from
Jun 26, 2024

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Jun 1, 2024

Addresses #134 :

This adds a command updateAlignment that can be applied to B3DM, I3DM, PNTS, and CMPT files, and just ensures that the elignment requirements for the batch- and feature table and the tile data as a whole are met.

I tested it with an old version of the CesiumJS spec data (the one before this commit), and it fixed most of the validation errors from that state. (Adding a spec could make sense, but ... creating the "invalid" data would take most of the time here...). In any case, the README.md still has to be updated.

@javagl
Copy link
Contributor Author

javagl commented Jun 26, 2024

I added specs based on the "old" CesiumJS specs data (one B3DM, I3DM, PNTS, and CMPT). They all caused validation errors before. The specs are comparing the result of running updateAlignment to the versions that are contained in the golden subdirectory, which no longer cause validation errors.

The README.md has been updated to include the updateAlignment command.

(An aside: One could make a case for adding this "alignment update" as part of the upgrade command. Technically, this would be trivial. But some details might have to be sorted out in terms of the desired configurability (even though the update options are not exposed right now beyond the targetVersion anyhow). Cases where someone wants to fix the alignment of a B3DM without upgrading its glTF 1.0 to 2.0, or someone wants to fix the alignment for B3DM and not for PNTS are unlikely, so it might just be part of the detault targetVersion=1.0 update...)

@javagl javagl marked this pull request as ready for review June 26, 2024 11:10
@lilleyse lilleyse merged commit ccbfbdc into main Jun 26, 2024
2 checks passed
@lilleyse lilleyse deleted the update-alignment branch June 26, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants