Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a command to fix certain alignment errors #134

Closed
javagl opened this issue May 28, 2024 · 1 comment
Closed

Consider a command to fix certain alignment errors #134

javagl opened this issue May 28, 2024 · 1 comment

Comments

@javagl
Copy link
Contributor

javagl commented May 28, 2024

This is a spin-off from #5 : The requirements for Padding in 3D Tiles - specifically, certain alignment requirements for tile content files like B3DM - have made their way into the specification relatively late. And there are still many B3DM files out there that do not meet these requirements. These files will be declared to be 'invalid' by the 3D Tiles Validator.

(In fact, even the spec files for CesiumJS did not meet these alignment requirements, and have been fixed only recently...)

While CesiumJS can process these files even when they do not meet these requirements, there is a huge potential for inconsistencies and fragmentation: Implementors should not be "forced" to be able to read "invalid" files.

Many of these alignment issues could be fixed relatively easily: The 3D Tiles Tools already offer the functionality to

The latter will already ensure most (all?) of the common alignment requirements.

So fixing the alignment could be a one-liner...
fs.writeFileSync("out", createTileDataBuffer(readTileData(fs.readFileSync("in")))
which should unfold only into "a few" real lines of code, with input/output type checks, 'overwrite' checks, and a proper command line command.

@javagl
Copy link
Contributor Author

javagl commented Jun 26, 2024

Fixed via #136

@javagl javagl closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant