Add a ShaderGen option to select the target MDL version #1417
Conversation
krohmerNV
force-pushed
the
PR-mdl-target-version
branch
from
985a390
to
7a7c20d
Compare
krohmerNV
force-pushed
the
PR-mdl-target-version
branch
2 times, most recently
from
0f45fb1
to
129b5f5
Compare
krohmerNV
force-pushed
the
PR-mdl-target-version
branch
from
129b5f5
to
3789c61
Compare
|
This looks like a really promising improvement, @krohmerNV, and let us know when you feel it's ready for review. |
|
@jstone-lucasfilm thanks! I'm working on a few test on our side to check if the generated code really works with old versions of our SDK. I don't plan to add major changes anymore. So, if you find time to review, I would very much appreciate it already. |
krohmerNV
force-pushed
the
PR-mdl-target-version
branch
from
2cde263
to
2839726
Compare
|
The overall structure of this proposal looks good to me, @krohmerNV, and I'm CC'ing @niklasharrysson for his thoughts and expertise. |
|
Sorry for the delay, I noticed this ping today. This looks good to me as well @krohmerNV , and I only had a few minor comments above. |
|
@niklasharrysson thanks for the review. |
… generate - This allows to generate MDL code for older applications while adding new features in the future. - Implemented geompropvalue functions using MDL 1.8 scene data_lookups to allow custom uv names for instance.
|
Thanks @krohmerNV, and let's definitely aim to include this change in 1.38.9 if you have the bandwidth to update it. |
krohmerNV
force-pushed
the
PR-mdl-target-version
branch
from
2839726
to
20646da
Compare
krohmerNV
changed the title
|
My local tests look fine. Ready from my side. |
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit de5c2b6
into
AcademySoftwareFoundation:main
This allows to generate MDL code for older applications while adding new features in the future.
It also to helps structuring changes and features depending on the MDL version.
Work in progress because i would like have feedback first.