Add fileTextureVerticalFlip option for MDL generation #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…additionally for texture lookups. this matches OSL and GLSL now.
krohmerNV
force-pushed
the
PR-MDL-fileTextureVerticalFlip
branch
from
f993ada
to
79ccb9c
Compare
Signed-off-by: krohmerNV <[email protected]>
krohmerNV
changed the title
|
@jstone-lucasfilm, I believe the discussion was closed. We want to flip in the test renderer to align with GLSL and OSL. I added comments to explain why this flip is done and how this is to be handled in integrations. |
|
This looks very promising, thanks @krohmerNV, and I'll plan to take a closer look soon! |
Signed-off-by: Jonathan Stone <[email protected]>
Signed-off-by: Jonathan Stone <[email protected]>
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Oct 31, 2023
jstone-lucasfilm
merged commit 50062e5
into
AcademySoftwareFoundation:main
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigating the differences in the MaterialXTest I implemented the fileTextureVerticalFlip in the MDL shader gen.
In theory this option is not needed because the MaterialX and MDL define the image coordinate both in the lower left.
But it might be useful to align with existing but non standard conform renderers. It could for instance be used in the MaterialXTest to align with the flipped GLSL and OSL results.
WIP because I guess we want to address/discuss this in the context of the MaterialXTest fixes
and it will probably conflict with #1417