Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent to ingest local files (by default) #2010

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Conversation

jaluma
Copy link
Collaborator

@jaluma jaluma commented Jul 23, 2024

Description

This PR aims to fix the security issue CVE-2024-3403. Although the Gradio part was already fixed several versions ago, this one aims to not be able to run the default ingestion script.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Contributor

@jaluma jaluma requested a review from imartinez July 29, 2024 11:51
imartinez
imartinez previously approved these changes Jul 31, 2024
Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with two minor comments

private_gpt/settings/settings.py Outdated Show resolved Hide resolved
scripts/ingest_folder.py Outdated Show resolved Hide resolved
Copy link
Contributor

Copy link
Contributor

@jaluma jaluma requested a review from imartinez July 31, 2024 11:59
@jaluma jaluma merged commit e54a8fe into main Jul 31, 2024
8 checks passed
@jaluma jaluma deleted the fix/local-ingestion branch July 31, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants