Support macOS Packed Structs #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Tôrres <[email protected]>
davidben
reviewed
Nov 25, 2019
| @@ -56,6 +56,78 @@ package krb5 | |||
| // krb5_data *outbuf) { | |||
| // return krb5_mk_req_extended(context, auth_context, ap_req_options, in_data, &in_creds, outbuf); | |||
| // } | |||
| // | |||
| // krb5_data *krb5_cc_get_principal_realm(krb5_principal_data *principal) { | |||
There was a problem hiding this comment.
krb5_cc_* is functions defined by Kerberos relating to the krb5_ccache. These functions are neither of these.
For the other wrappers, I made them file-local (static) which means they don't need a prefix since they don't get exported out of the cgo-generated C file.
| @@ -56,6 +56,78 @@ package krb5 | |||
| // krb5_data *outbuf) { | |||
| // return krb5_mk_req_extended(context, auth_context, ap_req_options, in_data, &in_creds, outbuf); | |||
| // } | |||
| // | |||
There was a problem hiding this comment.
Mind adding a short comment for why these are necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to pack pragma on
krb5.hthat is only used on macOS, some struct fields are not accessible from Go directly.In these cases is necessary to use an auxiliary function to get/set those fields.
Fixes golang/go#35640