Refactor #1523
Closed
Refactor #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix tests - Fix cssmin warnings
- Change jscs to eslinit - Change csslint to stylelint - Fix spellings - Swap css and jss tasks
This reverts commit 2c97e8b
|
@roniemartinez What about this one? |
|
@sauravkhdoolia Yeah I think I almost forgot this since no one reviewed it before. Will merge it. |
ksorv
reviewed
Jul 2, 2020
There was a problem hiding this comment.
There should have been two different PRs
- One for linter changes and other packages.
- Ome for style changes
This one has too many changes, all are totally different. Please look into it and try to break them in different PRs, would be of great help.
@roniemartinez Also this one contains files from /dist dir. Rejected.
Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description