Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-Fix: Add negative tags for RegexMultiplicationAST with min=0. #41

Open
wants to merge 110 commits into
base: main
Choose a base branch
from

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    a6274ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    186d239 View commit details
    Browse the repository at this point in the history
  3. Move LexicalRule to its own class; Change name to variable_id; Change…

    … tag to matching_variable_id; Use full names for vars (r->rule); Clarify if states are NFA or DFA
    SharafMohamed committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4f122c6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c24f6e1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    33582da View commit details
    Browse the repository at this point in the history
  6. Fix up some comments

    SharafMohamed committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3338ec7 View commit details
    Browse the repository at this point in the history
  7. Fix comment grammar

    SharafMohamed committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3cd3c0f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    e05acbb View commit details
    Browse the repository at this point in the history
  2. Use using to condense code; Use a unique schema object for each test …

    …for clairty that nothing is shared b/w tests
    SharafMohamed committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5e61e83 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    082090d View commit details
    Browse the repository at this point in the history
  4. Create and use RegexASTEmpty to split RegexASTgroup with min=0 into R…

    …egexASTgroup with min = 1 OR'd with RegexASTEmpty
    SharafMohamed committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2c6d94e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4e02f24 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bb3c543 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Return by value in literal getters; Use const instead of const& for l…

    …iteral arguments; Use const& for non-literals; Use auto where possible; Use uint32_t over int for ids; replace begin() and end() with cbegin() and cend()
    SharafMohamed committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    54027ad View commit details
    Browse the repository at this point in the history
  2. Refactor new_state()

    SharafMohamed committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e58274f View commit details
    Browse the repository at this point in the history
  3. Rename get_first_matching_variable_ids() to get_matching_variable_ids…

    …(); Add docstrign to RegexDFAStatePair
    SharafMohamed committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1321871 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c904755 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ffe9a0f View commit details
    Browse the repository at this point in the history
  6. Const and auto changes

    SharafMohamed committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    913ed1a View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Changed AST add functions to indicate the AST are being added to the …

    …NFA; Made add to nfa functions const
    SharafMohamed committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7aa8a92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    77e44a5 View commit details
    Browse the repository at this point in the history
  3. Merged with previous PR

    SharafMohamed committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d1d87e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f386a3b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0c600d7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bedad75 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    053d057 View commit details
    Browse the repository at this point in the history
  2. updated examples to use

    SharafMohamed committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a822307 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0b9603a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2ef84d1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    83bd518 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d3d815e View commit details
    Browse the repository at this point in the history
  7. Grammar fix

    SharafMohamed committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    168adb0 View commit details
    Browse the repository at this point in the history
  8. Typo fix

    SharafMohamed committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    20b3421 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5231a4a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    e4ac215 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b8b13e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e2d05fa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    660eb9b View commit details
    Browse the repository at this point in the history
  5. Change capture groups to assign tag when its originally added to the …

    …AST; Create a static id tracker for capture group ids and reset it when creating a SchemaParser; Rename add_tags to assign_negative_and_collect_positive_descendent_tags
    SharafMohamed committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    731b9fe View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    81b4ffa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4d29a5 View commit details
    Browse the repository at this point in the history
  3. Removed serializing AST without tags as this intermediate representat…

    …ion was just for testing during development. I don't see a need for it in the production version
    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9379447 View commit details
    Browse the repository at this point in the history
  4. Fix docstring tense; Add [[nodiscard]] and const to serialize functio…

    …ns; Remove reference to literal types; Use push_back instead of += for adding char to string; Use constexpr string_view for test case
    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6c4d933 View commit details
    Browse the repository at this point in the history
  5. Fix linter error

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a2fdbf1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b0485f5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    64da95c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e5bda43 View commit details
    Browse the repository at this point in the history
  9. Use fmt in serialize

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0ac7c43 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    529dcb2 View commit details
    Browse the repository at this point in the history
  11. Remove fetching fmt

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2e17bee View commit details
    Browse the repository at this point in the history
  12. Fetch fmt with QUIET

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    013765b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    14cbe97 View commit details
    Browse the repository at this point in the history
  14. Find after fetch

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    20864d6 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    72e61f6 View commit details
    Browse the repository at this point in the history
  16. Fix fmt tag in fetch

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    aadb290 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    c9d5510 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    f138527 View commit details
    Browse the repository at this point in the history
  19. Update fetch fmt

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4cc5e2a View commit details
    Browse the repository at this point in the history
  20. fmt debug cmake

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e08e345 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    ea5121a View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    2ff09b5 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    69cdd1f View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    f580cdd View commit details
    Browse the repository at this point in the history
  25. Fix type in ftm include

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c0dd3fe View commit details
    Browse the repository at this point in the history
  26. Cmake test

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    df12855 View commit details
    Browse the repository at this point in the history
  27. Cmake test2

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    be00753 View commit details
    Browse the repository at this point in the history
  28. Cmake test3

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2f47770 View commit details
    Browse the repository at this point in the history
  29. Cmake test4

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a15365b View commit details
    Browse the repository at this point in the history
  30. Cmake test5

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    239ff76 View commit details
    Browse the repository at this point in the history
  31. Fix cmake indentation

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2826461 View commit details
    Browse the repository at this point in the history
  32. Fix cmake indentation

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    db42bd8 View commit details
    Browse the repository at this point in the history
  33. Remove space in cmake

    SharafMohamed committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d5eeb5a View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    ce2fc76 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9643138 View commit details
    Browse the repository at this point in the history
  3. For serialize functions use const and make nullptr checks explicit; F…

    …or serializing negative tags use reserve and emplace_back.
    SharafMohamed committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    550961e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    74c46ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    29e0777 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cde19a6 View commit details
    Browse the repository at this point in the history
  7. Remove <format>

    SharafMohamed committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9837c10 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dac2122 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    aa4a4e4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e00fead View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    63fd9da View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    a5eae39 View commit details
    Browse the repository at this point in the history
  2. Remove irrelevent comment from clang-tidy (also fixes the previously …

    …out-of-order comments); Add comment explaining why <format> isn't sued to cmake
    SharafMohamed committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7b73929 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c62d8c View commit details
    Browse the repository at this point in the history
  4. Merge with previous PR

    SharafMohamed committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    033928f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1b6cd08 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bc4444a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge with previous PR

    SharafMohamed committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    48cea41 View commit details
    Browse the repository at this point in the history
  2. Fix formatting

    SharafMohamed committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    547bef4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c73c72c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f364aac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e93ea4f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c2933f3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f195955 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    37dfdca View commit details
    Browse the repository at this point in the history
  9. Add test case for validity; Fix typo in test case name; Fix docstring…

    …s for methods; Combine empty definitio nwith declaration.
    SharafMohamed committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3e64e7c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    69af073 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    14f9f69 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e49421a View commit details
    Browse the repository at this point in the history
  13. Correct tag for boost.

    SharafMohamed committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5ca7b4e View commit details
    Browse the repository at this point in the history
  14. Correct tag for boost.

    SharafMohamed committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2c72410 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f113c19 View commit details
    Browse the repository at this point in the history
  16. Enable boost in cmake.

    SharafMohamed committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    064379c View commit details
    Browse the repository at this point in the history
  17. Fix typo.

    SharafMohamed committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bf06d33 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    34f9e4f View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    af61ee1 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    9329cc8 View commit details
    Browse the repository at this point in the history
  21. Undo cmake changes.

    SharafMohamed committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ede2a16 View commit details
    Browse the repository at this point in the history