XEP-0198: Clarify server enabling SM without requested resumption #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Council
When a client requests stream management to be enabled and asks for stream resumption, it's not unreasonable for people to assume that the server may 'fail' the request if it doesn't offer the requested resumption. The pre-existing test does allow the server to enable SM _without_ the requested resumption feature, but isn't overly clear. This commit adds an example clarifying this scenario.
guusdk
force-pushed
the
XEP-0198_5_Enable-without-resumption
branch
from
26710a0
to
3a6253f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client requests stream management to be enabled and asks for stream resumption, it's not unreasonable for people to assume that the server may 'fail' the request if it doesn't offer the requested resumption. The pre-existing test does allow the server to enable SM without the requested resumption feature, but isn't overly clear.
This commit adds a note clarifying this scenario (and provides a rationale).
This was discussed briefly in the XSF Discussion MUC.