Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture subprocess stdout by default #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

joouha
Copy link
Contributor

@joouha joouha commented May 22, 2023

This PR sets the standard output of subprocess to be captured by default in the xonsh kernel.

This means that the output of external commands will sent to connected kernel clients, instead of being displayed in the terminal where the kernel is running.

@joouha joouha changed the title Always capture subprocess stdout Capture subprocess stdout by default May 23, 2023
@anki-code anki-code self-requested a review May 23, 2023 11:38
@anki-code
Copy link
Member

anki-code commented May 23, 2023

hi @joouha!
This is not working for me:

xonsh
xpip install -U git+https://github.com/joouha/xontrib-jupyter@fix-subproc-stdout
cd /tmp
euporie-notebook --kernel-name xonsh
image

If I run this many times:

  • sometimes I see just 1
  • sometimes I see just 1 2
  • sometimes I see just 1 <ls result> (without 2)

@anki-code
Copy link
Member

@joouha what do you think, why we have unstable output?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants