-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESLint plugin load error #589
Conversation
# Conflicts: # lib/options-manager.js
@@ -289,6 +290,9 @@ const buildESLintConfig = options => config => { | |||
}; | |||
} | |||
|
|||
// Resolve plugins from XO root directory | |||
config.resolvePluginsRelativeTo = MODULE_DIRECTORY; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this make it impossible for users to add ESLint plugins themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in eslint-plugin-unicorn
, it can load eslint-plugin-eslint-plugin
.
Does this also fix #555? |
I'm not sure, but I don't think this will fix that, the |
I feel this PR is not a good solution now, I think this may break monorepo. I'm going to convert it to draft. |
I thought I found a better solution, but it didn't work. I've opened an issue in ESLint, if it get fixed, maybe we can pass plugins that |
The issue you opened upstream has been fixed 🚀 |
In that case this can be fixed by load plugins ourselves. I don't have time to work on this. It will be great if someone want give this a shot. BTW, ESLint have a new |
I'm going to close this since it's old. The flat config will eventually fix this issue anyway: |
Fixes #546
I think the only problem is, user can override plugins before, but now can't, ESLint will always load the plugins
xo
installed.I saw a comment from #546, but I'm not sure what the problem is.