Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open/close instead of stream:stream #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Pitel
Copy link

@Pitel Pitel commented Sep 11, 2014

This change makes it compatible with latest draft (in fact, this has been there since revison 01), where <stream:stream> and </stream:stream> has been replaced with <open/> and <close/>.

This makes it work with latest stanza.io, but probably breaks clients still relying on old <stream:stream> method.

@Pitel
Copy link
Author

Pitel commented Dec 11, 2014

Ok, I've update the readme. Is this enough, or do you want more?

@Gordin
Copy link

Gordin commented Feb 2, 2015

Can this be merged? This would make node-xmpp-bosh work with the letast versions of stanza.io and latest HEAD of strophe.js (I want to make a new strophe.js release when this is merged) without workarounds.
Also, releasing a new version with this would be nice for packaging.

@kochka
Copy link

kochka commented Feb 24, 2015

Yes, a merge would be cool 👍

@ffPjrZUGXfcxuAj
Copy link

It's possible not break compatibility with old stream:stream client?

@Gordin
Copy link

Gordin commented May 6, 2015

@camaran No, the new protocol is not backwards-compatible. The only thing you could do is implement both protocols, try the current one and if authentication fails try the deprecated protocol. Ideally we should just drop the deprecated protocol altogether though, all servers support the current protocol by now, node-xmpp-bosh is one of the last XMPP Servers/Proxies that still uses the deprecated protocol.
@dhruvbird Is there still a reason why you are not merging this?

@ffPjrZUGXfcxuAj
Copy link

@Gordin for example Jappix client not support the new protocol

@Gordin
Copy link

Gordin commented May 6, 2015

@camaran Someone should file a bug with Jappix then, the old protocol is deprecated since February 2014 now… (Plus the changes on the client side are really not that big, they're just not compatible)

@BenV BenV mentioned this pull request Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants