Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use streams because this is literally just a stream recreation #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use streams because this is literally just a stream recreation #1

wants to merge 4 commits into from

Commits on Jul 6, 2019

  1. Use streams because this is literally just a stream recreation

    @miyoyo
    miyoyo authored Jul 6, 2019
    Configuration menu
    Copy the full SHA
    9a7deb4 View commit details
    Browse the repository at this point in the history

  2. Fix multiple calls to fetch

    @miyoyo
    miyoyo authored Jul 6, 2019
    Configuration menu
    Copy the full SHA
    b6f246f View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Don't fetch the stream twice, but grab a reference instead. 

    Boosts speed significantly
    @miyoyo
    miyoyo authored Jul 9, 2019
    Configuration menu
    Copy the full SHA
    d424d34 View commit details
    Browse the repository at this point in the history

  2. Cast the target to avoid a runtime type error. 

    Vastly faster than wrapping the callback, and, since we create the streamcontroller right above, the `as` is safe.
    @miyoyo
    miyoyo authored Jul 9, 2019
    Configuration menu
    Copy the full SHA
    72bedf5 View commit details
    Browse the repository at this point in the history