Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log info for missing values instead of showing errors. #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmooney
Copy link
Member

@tmooney tmooney commented Mar 23, 2023

If an optional output had no value (i.e., was null in the JSON), then we'd see this error:

[ERROR] Don't know how to download type <class 'NoneType'>. Full object: None

Now instead this case will log an info message like:

[INFO] Skipping optional output that wasn't defined: some_optional_value

Copy link
Member

@chrisamiller chrisamiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - nice improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants