Remove redundant Login and Sign Up links from home.html #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redundant Login/Sign-Up Links: In the base.html, the navigation bar already contains links for Login and Sign Up for unauthenticated users, and these links are being repeated in the home.html file under the {% if user.is_authenticated %} block for unauthenticated users as well. This redundancy can lead to unnecessary repetition in the UI.
Specifically:
In the base.html file, there's a Login and Sign Up button for users who are not authenticated.
In home.html, similar logic is implemented, but those links are not needed because the base template already handles this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the redundancy of the Login and Sign Up links in the project.
The Login and Sign Up links are already included in the
base.htmlfile for unauthenticated users, specifically in the navigation bar. These links were unintentionally duplicated inhome.htmlunder the{% if user.is_authenticated %}block for unauthenticated users. This redundancy led to unnecessary repetition in the UI.Changes:
home.html, as they were already being handled bybase.html.Reason for Change:
base.htmltemplate already contains the necessary logic to display Login and Sign Up buttons for unauthenticated users. Therefore, having these links again inhome.htmlwas redundant and unnecessary.Result:
Before:
After:
