Fix for regexp replacements used by verify steps #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shortly tested on local. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on this workshopper, I ran into some problems verifying my solutions.
The generated HTML was being mangled by the regexp replacements, probably due to newline differences. The output was rather confusing and it took me a while to figure out. Hopefully this can prevent that experience for others. I think it's the same problem described in #103.
I've been using a newer version of React for the workshopper, which is likely why I ran into this problem.
With the changes in this pull request, the workshopper should continue to work with React 0.14 as well as newer versions. Additional changes are necessary to bring the exercises and solutions up to date with React 15.5, but this should help along the way.