Remove legacy iOS localization actions and related helpers #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have newer, better actions to achieve the same results: - `ios_generate_strings_file_from_code` - `ios_extract_keys_from_strings_files` - `ios_download_strings_files_from_glotpress` - `ios_merge_strings_files`
mokagio
commented
Jun 2, 2022
| Fastlane::Helper::GitHelper.commit(message: 'Update metadata translations', files: './fastlane/metadata/', push: true) | ||
| end | ||
|
|
||
| def self.strings_files |
There was a problem hiding this comment.
This method is only used in the two methods deleted above.
This was referenced Jan 24, 2023
|
Superseded by #447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked!I was comfortable opening this because, once woocommerce/woocommerce-ios#7032 will be merged, both WordPress and WooCommerce iOS won't depend on these actions anymore. Simplenote iOS and macOS still do, but they are on hold and we have Semantic Versioning (merging this would count as a breaking change) on our side to prevent issues there (besides, if we'll pick up development on those platforms it would only make sense to spend the time to upgrade the tooling then).But... I forgot about Pocket Casts iOS. The app is actively in development and uses these legacy APIs. I think the best play for me is to work on converting that one, too, while I have all the know-how "fresh" in my mind.Update Pocket Casts iOS no longer uses the legacy APIs.
We now have newer, better actions to achieve the same results:
ios_generate_strings_file_from_codeios_extract_keys_from_strings_filesios_download_strings_files_from_glotpressios_merge_strings_files