Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate console command for --keep flag #221

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

derekblank
Copy link
Contributor

@derekblank derekblank commented Nov 8, 2023

When testing patch releases, I noted that there are duplicate console.Info declarations in the CLI when running the prepare command with the --keep flag:

[INFO] Finished preparing Gutenberg Mobile PR
[INFO] 
Finished preparing PRs:
https://github.com/derekblank/gutenberg/pull/30
https://github.com/derekblank/gutenberg-mobile/pull/9
[INFO] Keeping temporary directory /var/folders/xk/xmtl5xjx33v_bp94749wm0j00000gn/T/gbm-1558918830
[INFO] Keeping temporary directory /var/folders/xk/xmtl5xjx33v_bp94749wm0j00000gn/T/gbm-1558918830

This PR removes the console.Info in setCleaner.

Testing

  1. Run prepare all with the --keep flag, e.g.: go run main.go release prepare all 1.115.2 --keep
  2. Note only one "Keeping temporary directory [...]" line is logged to the console.

Copy link
Member

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@derekblank derekblank merged commit 73a5f1f into trunk Nov 8, 2023
2 checks passed
@derekblank derekblank deleted the cli/remove-duplicate-console branch November 8, 2023 23:11
@jhnstn jhnstn mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants