Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Use npm install when setting up Gutenberg #200

Merged
merged 3 commits into from
Oct 27, 2023
Merged

CLI: Use npm install when setting up Gutenberg #200

merged 3 commits into from
Oct 27, 2023

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Oct 26, 2023

Gutenberg has a package-lock linter to make sure the local package versions match what's in the package lock.
Running npm ci won't update the lock file but npm i will

This changes the npm command to use install

Testing:

  • Try preparing Gutenberg for a release
  • Verify that the root package-lock.json file is updated.

@jhnstn jhnstn mentioned this pull request Oct 26, 2023
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@jhnstn jhnstn merged commit 3f7f984 into trunk Oct 27, 2023
1 of 2 checks passed
@jhnstn jhnstn deleted the cli/fix-gb branch October 27, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants