Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add push tag flow to creating the gb release #190

Merged
merged 11 commits into from
Oct 24, 2023
Merged

CLI: Add push tag flow to creating the gb release #190

merged 11 commits into from
Oct 24, 2023

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Oct 23, 2023

Fixes #173
Depends on changes from #188

This adds a release tag to the Gutenberg repo after the PR is created.

Testing:

  • Run the release prepare gb {version} command against a fork of Gutenberg
  • Note the "Adding release tag" message after confirming the PR creation
  • Verify that the tag is added to the remote repo.

@jhnstn jhnstn enabled auto-merge (squash) October 23, 2023 22:02
derekblank
derekblank approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@jhnstn jhnstn merged commit 001be8c into trunk Oct 24, 2023
2 checks passed
@jhnstn jhnstn deleted the cli/tag-gb branch October 24, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekblank derekblank derekblank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add release tag GB when preparing the release PR
2 participants
@jhnstn @derekblank