Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release tag GB when preparing the release PR #173

Closed
jhnstn opened this issue Oct 17, 2023 · 0 comments · Fixed by #190
Closed

Add release tag GB when preparing the release PR #173

jhnstn opened this issue Oct 17, 2023 · 0 comments · Fixed by #190
Assignees

Comments

@jhnstn
Copy link
Member

jhnstn commented Oct 17, 2023

In the current release flow we add the release tag to GB after reviewing the PR.
In most cases we shouldn't need to wait for the review to add the tag since we rarely make changes to the GB pr once it's ready to review.

We can add some other flows to move the tag if needed and have the release publish (see #172) command verify that the tag is pointing to the last commit in the release pr

@derekblank derekblank changed the title Add release tag GB when prepareing the release PR Add release tag GB when preparing the release PR Oct 19, 2023
@jhnstn jhnstn self-assigned this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant