Node with JDK17 #9
Conversation
Those packages seems to be broken via apt-get. Also, we install them via `sdkmanager` in next steps.
It has preinstalled JDK17 (which was problematic to install on Debian). Also, we don't have to cache Gradle because it's preinstalled.
I'm not sure how it was working previously, but now it was failing with `nvm command not found`
There was a problem hiding this comment.
I didn't test the Docker image per se but the changes matches what is described in the individual commit messages and in the PR description, so as long as it works as expected when used in wordpress-mobile/react-native-libraries-publisher#36 that should be ok.
Up to you to publish the image and merge the PR, or not publish it (ref by sha1 only) and close that PR like was done with #7 — both works for me, as long has we have the history of the Dockerfile used for a given sha1 (here I'm assuming 9d1710c7d74d1349d84e94465fe7b3a90216e92a, since that's the one used in wordpress-mobile/react-native-libraries-publisher#36)
|
|
||
| RUN rm /bin/sh && ln -s /bin/bash /bin/sh | ||
|
|
||
| # Increase the file watcher limit for node. This should not be necessary for CI builds since watchers should be disabled, but it can be useful when running this image in a local environment. | ||
| RUN echo fs.inotify.max_user_watches=524288 | tee -a /etc/sysctl.conf |
| RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash \ | ||
| && source "$HOME/.nvm/nvm.sh" \ | ||
| && nvm install $NODE_VERSION | ||
| ENV PATH="//root/.nvm/versions/node/$NODE_VERSION/bin:${PATH}" |
There was a problem hiding this comment.
| ENV PATH="//root/.nvm/versions/node/$NODE_VERSION/bin:${PATH}" | |
| ENV PATH="/root/.nvm/versions/node/$NODE_VERSION/bin:${PATH}" |
| && nvm install $NODE_VERSION | ||
| ENV PATH="//root/.nvm/versions/node/$NODE_VERSION/bin:${PATH}" | ||
|
|
||
| RUN which npm |
There was a problem hiding this comment.
Just curious: what made npm be installed in that Docker image? Is it installed as part of the nvm install script (curl -o- …/nvm/v0.39.7/install.sh)?
Description
This PR adds JDK 17, Gradle
8.2.1andnpmto the image. For more context about certain decisions, please see commit messages.Used in: wordpress-mobile/react-native-libraries-publisher#36
This is probably not gonna to be merged, similarly to #7